This is an archive of the discontinued LLVM Phabricator instance.

Differential D148562

[InstCombine][NFC] Add tests for simplifying select(X|Y,X|Y,X) to X|Y
ClosedPublic

Authored by HerrCai0907 on Apr 17 2023, 12:54 PM.

Details

Reviewers
nikic
Commits
rGbeefca7239fc: [InstCombine][NFC] Add tests for simplifying select(X|Y,X|Y,X) to X|Y

Diff Detail

Unit TestsFailed

TimeTest
60,050 msx64 debian > MLIR.Examples/standalone::test.toy

Event Timeline

HerrCai0907 created this revision.Apr 17 2023, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 12:54 PM
HerrCai0907 requested review of this revision.Apr 17 2023, 12:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 17 2023, 12:54 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
HerrCai0907 added a parent revision: D148275: [InstCombine] support fold select(X|Y,X|Y,X) to X|Y.Apr 17 2023, 12:54 PM
nikic accepted this revision.Apr 17 2023, 1:04 PM
nikic added a subscriber: nikic.

LGTM

This revision is now accepted and ready to land.Apr 17 2023, 1:04 PM
Herald added a subscriber: StephenFan. · View Herald TranscriptApr 17 2023, 1:04 PM
This revision was landed with ongoing or failed builds.Apr 17 2023, 1:07 PM
Closed by commit rGbeefca7239fc: [InstCombine][NFC] Add tests for simplifying select(X|Y,X|Y,X) to X|Y (authored by HerrCai0907). · Explain Why
This revision was automatically updated to reflect the committed changes.
HerrCai0907 added a commit: rGbeefca7239fc: [InstCombine][NFC] Add tests for simplifying select(X|Y,X|Y,X) to X|Y.
Harbormaster completed remote builds in B226198: Diff 514372.Apr 17 2023, 2:39 PM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstSimplify/
211 lines

Diff 514372

llvm/test/Transforms/InstSimplify/select_or_and.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt -S -passes=instsimplify < %s | FileCheck %s
; select(Y | X == 0, X, Y | X)
define i32 @select_or_1(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_1(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[OR]], 0
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[X]], i32 [[OR]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp eq i32 %or, 0
%ret = select i1 %cmp, i32 %x, i32 %or
ret i32 %ret
}
; select(Y | X == 0, Y, Y | X)
define i32 @select_or_2(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_2(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[OR]], 0
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[OR]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp eq i32 %or, 0
%ret = select i1 %cmp, i32 %y, i32 %or
ret i32 %ret
}
; select(Y | X != 0, Y | X, X)
define i32 @select_or_3(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_3(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[OR]], 0
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[OR]], i32 [[X]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp ne i32 %or, 0
%ret = select i1 %cmp, i32 %or, i32 %x
ret i32 %ret
}
; select(Y | X != 0, Y | X, Y)
define i32 @select_or_4(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_4(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[OR]], 0
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[OR]], i32 [[Y]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp ne i32 %or, 0
%ret = select i1 %cmp, i32 %or, i32 %y
ret i32 %ret
}
; select(Y | X != 0, Y | X, Y)
define <4 x i32> @select_or_vec(<4 x i32> %x, <4 x i32> %y) {
; CHECK-LABEL: @select_or_vec(
; CHECK-NEXT: [[OR:%.*]] = or <4 x i32> [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne <4 x i32> [[OR]], zeroinitializer
; CHECK-NEXT: [[RET:%.*]] = select <4 x i1> [[CMP]], <4 x i32> [[OR]], <4 x i32> [[Y]]
; CHECK-NEXT: ret <4 x i32> [[RET]]
;
%or = or <4 x i32> %y, %x
%cmp = icmp ne <4 x i32> %or, zeroinitializer
%ret = select <4 x i1> %cmp, <4 x i32> %or, <4 x i32> %y
ret <4 x i32> %ret
}
; select(Y | X == 0, Y | X, Y)
define i32 @select_or_not_1(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_not_1(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[OR]], 0
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[OR]], i32 [[Y]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp eq i32 %or, 0
%ret = select i1 %cmp, i32 %or, i32 %y
ret i32 %ret
}
; select(Y | X != 0, Y, Y | X)
define i32 @select_or_not_2(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_not_2(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[OR]], 0
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[OR]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp ne i32 %or, 0
%ret = select i1 %cmp, i32 %y, i32 %or
ret i32 %ret
}
; select(Y | X != 1, Y, Y | X)
define i32 @select_or_not_3(i32 %x, i32 %y) {
; CHECK-LABEL: @select_or_not_3(
; CHECK-NEXT: [[OR:%.*]] = or i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[OR]], 1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[OR]]
; CHECK-NEXT: ret i32 [[RET]]
;
%or = or i32 %y, %x
%cmp = icmp ne i32 %or, 1
%ret = select i1 %cmp, i32 %y, i32 %or
ret i32 %ret
}
; select(Y & X == -1, X, Y & X)
define i32 @select_and_1(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_1(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[AND]], -1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[X]], i32 [[AND]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp eq i32 %and, -1
%ret = select i1 %cmp, i32 %x, i32 %and
ret i32 %ret
}
; select(Y & X == -1, Y, Y & X)
define i32 @select_and_2(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_2(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[AND]], -1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[AND]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp eq i32 %and, -1
%ret = select i1 %cmp, i32 %y, i32 %and
ret i32 %ret
}
; select(Y & X != -1, Y & X, X)
define i32 @select_and_3(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_3(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[AND]], -1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[AND]], i32 [[X]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp ne i32 %and, -1
%ret = select i1 %cmp, i32 %and, i32 %x
ret i32 %ret
}
; select(Y & X != -1, Y & X, Y)
define i32 @select_and_4(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_4(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[AND]], -1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[AND]], i32 [[Y]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp ne i32 %and, -1
%ret = select i1 %cmp, i32 %and, i32 %y
ret i32 %ret
}
; select(Y & X != -1, Y, Y & X)
define i32 @select_and_not_1(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_not_1(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp eq i32 [[AND]], -1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[AND]], i32 [[Y]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp eq i32 %and, -1
%ret = select i1 %cmp, i32 %and, i32 %y
ret i32 %ret
}
; select(Y & X != -1, Y, Y & X)
define i32 @select_and_not_2(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_not_2(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[AND]], -1
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[AND]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp ne i32 %and, -1
%ret = select i1 %cmp, i32 %y, i32 %and
ret i32 %ret
}
; select(Y & X != 123, Y, Y & X)
define i32 @select_and_not_3(i32 %x, i32 %y) {
; CHECK-LABEL: @select_and_not_3(
; CHECK-NEXT: [[AND:%.*]] = and i32 [[Y:%.*]], [[X:%.*]]
; CHECK-NEXT: [[CMP:%.*]] = icmp ne i32 [[AND]], 123
; CHECK-NEXT: [[RET:%.*]] = select i1 [[CMP]], i32 [[Y]], i32 [[AND]]
; CHECK-NEXT: ret i32 [[RET]]
;
%and = and i32 %y, %x
%cmp = icmp ne i32 %and, 123
%ret = select i1 %cmp, i32 %y, i32 %and
ret i32 %ret
}