This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] CSharp don't allow there not to be a space between `is` and `[`
ClosedPublic

Authored by MyDeveloperDay on Apr 16 2023, 9:25 AM.

Details

Summary

as is is a keyword in C# ensure there is always a space before the [ regardless of SpaceBeforeSquareBrackets setting

Fixes: #61965

https://github.com/llvm/llvm-project/issues/61965

Diff Detail

Event Timeline

MyDeveloperDay created this revision.Apr 16 2023, 9:25 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 16 2023, 9:25 AM
MyDeveloperDay requested review of this revision.Apr 16 2023, 9:25 AM
This revision is now accepted and ready to land.Apr 16 2023, 12:02 PM
owenpan accepted this revision.Apr 16 2023, 7:07 PM
owenpan added inline comments.
clang/unittests/Format/FormatTestCSharp.cpp
1182–1186

Should we end the return statements with a semicolon?

This revision was landed with ongoing or failed builds.Apr 17 2023, 11:40 AM
This revision was automatically updated to reflect the committed changes.
MyDeveloperDay marked an inline comment as done.