This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Fix minor issues in AdvancedBuilds documentation
ClosedPublic

Authored by aidengrossman on Apr 16 2023, 12:01 AM.

Details

Summary

This patch modifies the commands under the Bootstrap builds section so
that they include the -DLLVM_ENABLE_PROJECTS flag with the value "clang"
so that the Clang build will actually get picked up. Without this patch
they error out as the CLANG_BOOTSTRAP_PASSTHROUGH variable is processed
in /clang/CMakeLists.txt which isn't picked up without the
LLVM_ENABLE_PROJECTS variable being set appropriately.

This patch also changes any remaining dangling <path to source>
references to <path to source>/llvm to better match the rest of the
file.

Diff Detail

Event Timeline

aidengrossman created this revision.Apr 16 2023, 12:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2023, 12:01 AM
aidengrossman requested review of this revision.Apr 16 2023, 12:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 16 2023, 12:01 AM

Based on some discussion that happened on Discord where someone has having trouble getting a multi-stage build to work using this documentation as the LLVM_ENABLE_PROJECTS variable wasn't set.

thieta accepted this revision.Apr 24 2023, 3:35 AM

LGTM thanks!

This revision is now accepted and ready to land.Apr 24 2023, 3:35 AM