Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[clang-format] Dont interpret variable named interface as keyword for C++

Authored by sousajo on Apr 15 2023, 11:13 AM.

Diff Detail

Event Timeline

sousajo created this revision.Apr 15 2023, 11:13 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptApr 15 2023, 11:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
sousajo requested review of this revision.Apr 15 2023, 11:13 AM
This revision is now accepted and ready to land.Apr 15 2023, 12:56 PM

As I dont have commit access if someone can land It for me:

Jorge Pinto Sousa

owenpan added inline comments.Apr 15 2023, 1:26 PM

The default style is LLVM.

sousajo updated this revision to Diff 513945.Apr 15 2023, 3:54 PM
  • removed FormatStyle Style = getLLVMStyle(); as llvm is the default style
sousajo updated this revision to Diff 513946.Apr 15 2023, 3:54 PM
sousajo marked 2 inline comments as done.
  • inline string to be checked
owenpan accepted this revision.Apr 15 2023, 5:11 PM
sousajo updated this revision to Diff 513969.Apr 16 2023, 12:11 AM
  • rebased
MyDeveloperDay accepted this revision.Apr 16 2023, 2:10 AM

cannot reproduce the build failure locally. if this looks fine can someone land it for me? or should we wait until we have a green build after rebase?

This revision was landed with ongoing or failed builds.Apr 16 2023, 3:25 AM
This revision was automatically updated to reflect the committed changes.