Implements parts of P1614R2
Implemented operator<=> for multiset and set
Paths
| Differential D148416
[libc++][spaceship] Implement `operator<=>` for `multiset` and `set` ClosedPublic Authored by H-G-Hristov on Apr 15 2023, 12:32 AM.
Details
Summary Implements parts of P1614R2 Implemented operator<=> for multiset and set
Diff Detail
Event TimelineComment Actions I assume this passed the CI checks, so I'd like to put it for review/discussion as is. NOTE: Unlike any other container (including std::multisite) "unorderable" values are not added to std::set. I couldn't find an explanation for that, so I hope for a feedback. I think libstdc++'s std::set behaves in the same way. Comment Actions Thanks for working on this. Some comments.
Comment Actions @Mordante Thank you for the comments. Sorry about answering your question with questions though.
Comment Actions LGTM modulo one nit.
This revision is now accepted and ready to land.May 22 2023, 10:26 AM
Comment Actions Updated // expected-error tests in *.verify.cpp according the review comments in D151205 Comment Actions @Mordante I made a slight adjustments to the tests after your approval, if you don't mind I'll wait for a few days and I'll land it. Closed by commit rGf8b5ac34adb9: [libc++][spaceship] Implement `operator<=>` for `multiset` and `set` (authored by Zingam). · Explain WhyMay 28 2023, 11:00 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 521982 libcxx/include/set
libcxx/test/std/containers/associative/multiset/multiset.nonmember/compare.three_way.pass.cpp
libcxx/test/std/containers/associative/multiset/multiset.nonmember/compare.three_way.verify.cpp
libcxx/test/std/containers/associative/set/set.nonmember/compare.three_way.pass.cpp
libcxx/test/std/containers/associative/set/set.nonmember/compare.three_way.verify.cpp
libcxx/test/support/test_comparisons.h
libcxx/test/support/test_container_comparisons.h
|