[lldb/API] Add convenience constructor for SBError (NFC)

[mib]

Summary

This patch adds a new convience constructor to the SBError to initialize
it with a string message to avoid having to create the object and call
the SetErrorString method afterwards.

This is very handy to report errors from lldb scripted affordances.

Signed-off-by: Med Ismail Bennani <[e-mail]>

[bulbazord]

I like this! Reading through the call stack, it looks like we shouldn't hit any issues if message is nullptr. Could you add a small test to TestSBError.py constructing an error with a message directly?

[mib]

In D148401#4275398, @bulbazord wrote:

I like this! Reading through the call stack, it looks like we shouldn't hit any issues if message is nullptr. Could you add a small test to TestSBError.py constructing an error with a message directly?

Yep, we create the underlying status object if the opaque ptr is null. Will add a test case :)

[JDevlieghere]

lldb/include/lldb/API/SBError.h

26

Why not a StringRef?

[bulbazord]

lldb/include/lldb/API/SBError.h

26

I'm not sure we have StringRef type map in swig? We would have to create one for swig to pick up on it correctly, no?

[mib]

lldb/include/lldb/API/SBError.h

26

+1

[JDevlieghere]

lldb/include/lldb/API/SBError.h

26

Yeah nvm, I got Status and SBError confused.

lldb/include/lldb/API/SBError.h

 namespace lldb {
 
 class LLDB_API SBError {
 public:
   SBError();
 
   SBError(const lldb::SBError &rhs);
 
+  SBError(const char *message);
+
 #ifndef SWIG
   SBError(const lldb_private::Status &error);
 #endif
 
   ~SBError();
 
   const SBError &operator=(const lldb::SBError &rhs);
 

lldb/source/API/SBError.cpp

 SBError::SBError() { LLDB_INSTRUMENT_VA(this); }
 
 SBError::SBError(const SBError &rhs) {
   LLDB_INSTRUMENT_VA(this, rhs);
 
   m_opaque_up = clone(rhs.m_opaque_up);
 }
 
+SBError::SBError(const char *message) {
+  LLDB_INSTRUMENT_VA(this, message);
+
+  SetErrorString(message);
+}
+
 SBError::SBError(const lldb_private::Status &status)
     : m_opaque_up(new Status(status)) {
   LLDB_INSTRUMENT_VA(this, status);
 }
 
 SBError::~SBError() = default;
 
 const SBError &SBError::operator=(const SBError &rhs) {