LGTM with a nit.
|111 ↗||(On Diff #40650)|
This one ought to be ..._S1 and adjustFixupValue(), etc. should be corrected to match. Could you fix this in a separate patch?
|168 ↗||(On Diff #40650)|
We should also 'return 0' as per the other cases.
|370 ↗||(On Diff #40650)|
If my understanding is correct -4 is defined only by the size of current instruction (balc and bc in this case) and it is 4 bytes: