This is an archive of the discontinued LLVM Phabricator instance.

Differential D148151

[lldb] Add 'CHECK' to class-type-nullptr-deref.s test.
ClosedPublic

Authored by cmtice on Apr 12 2023, 11:25 AM.

Details

Reviewers
labath
rupprecht
jgorbe
Commits
rGbe58b42a7510: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test.
Summary

This test previously relied on just segfaulting or not. This commit adds a CHECK statement to the test that will only pass if the test does not segfault.

Diff Detail

Event Timeline

cmtice created this revision.Apr 12 2023, 11:25 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 12 2023, 11:25 AM
cmtice requested review of this revision.Apr 12 2023, 11:25 AM
Harbormaster completed remote builds in B225131: Diff 512911.Apr 12 2023, 11:28 AM
labath accepted this revision.Apr 13 2023, 7:39 AM
This revision is now accepted and ready to land.Apr 13 2023, 7:39 AM
Closed by commit rGbe58b42a7510: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test. (authored by cmtice). · Explain WhyApr 13 2023, 8:18 AM
This revision was automatically updated to reflect the committed changes.
cmtice added a commit: rGbe58b42a7510: [lldb] Add 'CHECK' to class-type-nullptr-deref.s test..
Herald added a project: Restricted Project. · View Herald TranscriptApr 13 2023, 8:19 AM
Herald added a subscriber: lldb-commits. · View Herald Transcript

Revision Contents

PathSize
lldb/
test/
Shell/
SymbolFile/
DWARF/
x86/
4 lines

Diff 513246

lldb/test/Shell/SymbolFile/DWARF/x86/class-type-nullptr-deref.s

# Test to verify that, if a class type pointer creation fails (pointer is # Test to verify that, if a class type pointer creation fails (pointer is
# null), LLDB does not try to dereference the null pointer. # null), LLDB does not try to dereference the null pointer.
# RUN: llvm-mc --triple x86_64-pc-linux %s --filetype=obj -o %t # RUN: llvm-mc --triple x86_64-pc-linux %s --filetype=obj -o %t
# RUN: %lldb %t -o "target variable x" -o exit 2>&1 # RUN: %lldb %t -o "target variable x" -o exit 2>&1 | FileCheck %s
# CHECK: 'Unable to determine byte size.'
# This tests a fix for a crash. If things are working we don't get a segfault. # This tests a fix for a crash. If things are working we don't get a segfault.
.type x,@object # @x .type x,@object # @x
.bss .bss
.globl x .globl x
x: x:
.quad 0 # 0x0 .quad 0 # 0x0
▲ Show 20 Lines • Show All 53 Lines • Show Last 20 Lines