libcxx: Bring back unsigned return from wcstoull_l

[cschlosser]

Summary

Got removed here:
21d9282ae2b6e1e7dfbabfd87f6208c3bdff8ea4#diff-e41832b8aa26da45585a57c5111531f2e1d07e91a67c4f8bf1cd6d566ae45a2bR40

[cschlosser]

Should I add a test for this as this is the second time (D141208) this has happened recently

[philnik]

In D148056#4259466, @cschlosser wrote:

Should I add a test for this as this is the second time (D141208) this has happened recently

We don't have a musl configuration in the CI, otherwise this would have been caught.

[cschlosser]

In D148056#4259520, @philnik wrote:

In D148056#4259466, @cschlosser wrote:

Should I add a test for this as this is the second time (D141208) this has happened recently

We don't have a musl configuration in the CI, otherwise this would have been caught.

I see, thanks.

The sanitizer builds are failing, I don't see how this is related though, especially as you mentioned that there isn't even a configuration for this part of the code.

[philnik]

In D148056#4260105, @cschlosser wrote:

In D148056#4259520, @philnik wrote:

In D148056#4259466, @cschlosser wrote:

Should I add a test for this as this is the second time (D141208) this has happened recently

We don't have a musl configuration in the CI, otherwise this would have been caught.

I see, thanks.

The sanitizer builds are failing, I don't see how this is related though, especially as you mentioned that there isn't even a configuration for this part of the code.

They are unrelated. I guess you don't have commit access?

[cschlosser]

In D148056#4261085, @philnik wrote:

In D148056#4260105, @cschlosser wrote:

In D148056#4259520, @philnik wrote:

In D148056#4259466, @cschlosser wrote:

Should I add a test for this as this is the second time (D141208) this has happened recently

We don't have a musl configuration in the CI, otherwise this would have been caught.

I see, thanks.

The sanitizer builds are failing, I don't see how this is related though, especially as you mentioned that there isn't even a configuration for this part of the code.

They are unrelated. I guess you don't have commit access?

No I don't, this is my first contribution.

Could you commit this for me please?

Also does it make sense to backport to 16?

[ldionne]

In D148056#4263105, @cschlosser wrote:

Could you commit this for me please?

Can you please provide Author Name <email@domain> we should use to contribute this with proper attribution?

Also does it make sense to backport to 16?

I guess it does.

Thanks!

[cschlosser]

In D148056#4332982, @ldionne wrote:

In D148056#4263105, @cschlosser wrote:

Could you commit this for me please?

Can you please provide Author Name <email@domain> we should use to contribute this with proper attribution?

I thought I added that to the commit but it should be Christoph Schlosser <[e-mail]>.

Also does it make sense to backport to 16?

I guess it does.

Thanks!

Is there a way to do this from the Web UI or should it go through the same flow as this review?

[Mordante]

In D148056#4447081, @cschlosser wrote:

In D148056#4332982, @ldionne wrote:

In D148056#4263105, @cschlosser wrote:

Could you commit this for me please?

Can you please provide Author Name <email@domain> we should use to contribute this with proper attribution?

I thought I added that to the commit but it should be Christoph Schlosser <[e-mail]>.

It was there, but it's not always the case.

Also does it make sense to backport to 16?

I guess it does.

Thanks!

Is there a way to do this from the Web UI or should it go through the same flow as this review?

Based on https://discourse.llvm.org/t/16-0-6-release/71344 there will be no more 16 releases. So it can't be backported.

I just landed this on your behalf so it will be in LLVM 17.

libcxx/include/__support/musl/xlocale.h

 strtoull_l(const char* __nptr, char** __endptr, int __base, locale_t) {
   return ::strtoull(__nptr, __endptr, __base);
 }
 
 inline _LIBCPP_HIDE_FROM_ABI_C long long wcstoll_l(const wchar_t* __nptr, wchar_t** __endptr, int __base, locale_t) {
   return ::wcstoll(__nptr, __endptr, __base);
 }
 
-inline _LIBCPP_HIDE_FROM_ABI_C long long wcstoull_l(const wchar_t* __nptr, wchar_t** __endptr, int __base, locale_t) {
+inline _LIBCPP_HIDE_FROM_ABI_C unsigned long long
+wcstoull_l(const wchar_t* __nptr, wchar_t** __endptr, int __base, locale_t) {
   return ::wcstoull(__nptr, __endptr, __base);
 }
 
 inline _LIBCPP_HIDE_FROM_ABI_C long double wcstold_l(const wchar_t* __nptr, wchar_t** __endptr, locale_t) {
   return ::wcstold(__nptr, __endptr);
 }
 
 #ifdef __cplusplus
 }
 #endif
 
 #endif // _LIBCPP___SUPPORT_MUSL_XLOCALE_H