This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizer][Test] Disable atos test on unknown address for ubsan
ClosedPublic

Authored by thetruestblue on Apr 10 2023, 4:04 PM.

Details

Summary

This test is failing for some cases in CI for ubsan. I suspect because
of the undefined behavior nature of the test, ubsan does not always
try to symbolicate or save the frame for the faulting address.

Specifically is failing on x86 CI. But making this unsupported on
ubsan for now.

rdar://107846128

Diff Detail

Event Timeline

thetruestblue created this revision.Apr 10 2023, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 4:04 PM
Herald added subscribers: Enna1, pengfei. · View Herald Transcript
thetruestblue requested review of this revision.Apr 10 2023, 4:04 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 10 2023, 4:04 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
yln accepted this revision.Apr 10 2023, 5:02 PM

LGTM! Nit: please add comment that explains "UBsan does not attempt to symbolicate this address" or "UBsan does not provide a trace" or similar (whatever makes sense).

This revision is now accepted and ready to land.Apr 10 2023, 5:02 PM