This is an archive of the discontinued LLVM Phabricator instance.

Differential D147760

[sanitizer] correct prctl scope
ClosedPublic

Authored by lizhiguang on Apr 6 2023, 7:42 PM.

Details

Reviewers
kongyi
kcc
vitalybuka
Commits
rG99ab3d9861bc: [sanitizer] correct prctl scope
Summary

prctl scope is wrong, i think this is typo, we should use:
REAL(prctl)(args...)

Diff Detail

Event Timeline

lizhiguang created this revision.Apr 6 2023, 7:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 7:42 PM
Herald added a subscriber: Enna1. · View Herald Transcript
lizhiguang requested review of this revision.Apr 6 2023, 7:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 6 2023, 7:42 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B224150: Diff 511592.Apr 6 2023, 8:10 PM
vitalybuka accepted this revision.Apr 11 2023, 7:07 PM
This revision is now accepted and ready to land.Apr 11 2023, 7:07 PM
vitalybuka added a comment.Apr 11 2023, 7:12 PM

Could you please provide git commit "Author:" string?

lizhiguang edited the summary of this revision. (Show Details)Apr 11 2023, 9:56 PM
In D147760#4259841, @vitalybuka wrote:

Could you please provide git commit "Author:" string?

Dear sir, please help to check, is it right now?

vitalybuka edited the summary of this revision. (Show Details)Apr 12 2023, 10:48 AM
Closed by commit rG99ab3d9861bc: [sanitizer] correct prctl scope (authored by lizhiguang, committed by vitalybuka). · Explain WhyApr 12 2023, 10:50 AM
This revision was automatically updated to reflect the committed changes.
vitalybuka added a commit: rG99ab3d9861bc: [sanitizer] correct prctl scope.

Revision Contents

PathSize
compiler-rt/
lib/
sanitizer_common/
2 lines

Diff 511592

compiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 1,344 Lines • ▼ Show 20 LinesINTERCEPTOR(int, prctl, int option, unsigned long arg2, unsigned long arg3,
static const int PR_SET_NAME = 15; static const int PR_SET_NAME = 15;
static const int PR_SET_VMA = 0x53564d41; static const int PR_SET_VMA = 0x53564d41;
static const int PR_SCHED_CORE = 62; static const int PR_SCHED_CORE = 62;
static const int PR_SCHED_CORE_GET = 0; static const int PR_SCHED_CORE_GET = 0;
if (option == PR_SET_VMA && arg2 == 0UL) { if (option == PR_SET_VMA && arg2 == 0UL) {
char *name = (char *)arg5; char *name = (char *)arg5;
COMMON_INTERCEPTOR_READ_RANGE(ctx, name, internal_strlen(name) + 1); COMMON_INTERCEPTOR_READ_RANGE(ctx, name, internal_strlen(name) + 1);
} }
int res = REAL(prctl(option, arg2, arg3, arg4, arg5)); int res = REAL(prctl)(option, arg2, arg3, arg4, arg5);
if (option == PR_SET_NAME) { if (option == PR_SET_NAME) {
char buff[16]; char buff[16];
internal_strncpy(buff, (char *)arg2, 15); internal_strncpy(buff, (char *)arg2, 15);
buff[15] = 0; buff[15] = 0;
COMMON_INTERCEPTOR_SET_THREAD_NAME(ctx, buff); COMMON_INTERCEPTOR_SET_THREAD_NAME(ctx, buff);
} else if (res != -1 && option == PR_SCHED_CORE && arg2 == PR_SCHED_CORE_GET) { } else if (res != -1 && option == PR_SCHED_CORE && arg2 == PR_SCHED_CORE_GET) {
COMMON_INTERCEPTOR_WRITE_RANGE(ctx, (u64*)(arg5), sizeof(u64)); COMMON_INTERCEPTOR_WRITE_RANGE(ctx, (u64*)(arg5), sizeof(u64));
} }
▲ Show 20 Lines • Show All 9,334 Lines • Show Last 20 Lines