Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Please see my comments.
| packages/Python/lldbsuite/test/lldbtest.py | ||
|---|---|---|
| 464 | I think in case of Android we can always treat result of parsed_url.netloc.split(":")[0] as a device id unless it's set to 'localhost' - it should hold true for any protocol scheme. | |
| packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py | ||
| 64–69 | You may use "unix-" to allow regular domain sockets as well. | |
| 69 | if host != 'localhost' ? | |
| packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py | ||
|---|---|---|
| 69 | As discussed offline, add check for remote platform is android as well. | |
Comment Actions
LGTM
| packages/Python/lldbsuite/test/lldbtest.py | ||
|---|---|---|
| 464 | Nit - you may save parsed_url.netloc.split(":")[0] as local variable like host_name | |
I think in case of Android we can always treat result of parsed_url.netloc.split(":")[0] as a device id unless it's set to 'localhost' - it should hold true for any protocol scheme.