After our discussion on IRC. Please forgive my bad english =)
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
TestingGuide.rst | ||
---|---|---|
243 ↗ | (On Diff #40348) | It is a good practice is worthless without a motivation, I think Eric needs to feed something here :) |
Comment Actions
LGTM.
Motivation: Fewer processes spawned for tests, this is particularly good on OSes that have slow forking code like OSX and Windows. Easier to find "what are the tests that are associated with this feature". I'm sure if you think about it you can probably come up with a few more. :)
Comment Actions
If launching less processes is a motivation, then not adding FileCheck when not needing (crash test) should be good practice :)
Comment Actions
Nope. Because you should have a check for some sort of reasonable behavior if possible. :)