This is an archive of the discontinued LLVM Phabricator instance.

[Documentation] Add guidelines for grouping tests together
ClosedPublic

Authored by davide on Nov 16 2015, 2:54 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

davide updated this revision to Diff 40348.Nov 16 2015, 2:54 PM
davide retitled this revision from to [Documentation] Add guidelines for grouping tests together.
davide updated this object.
davide added a subscriber: llvm-commits.
mehdi_amini added inline comments.
TestingGuide.rst
243 ↗(On Diff #40348)

It is a good practice is worthless without a motivation, I think Eric needs to feed something here :)

echristo accepted this revision.Nov 16 2015, 2:59 PM
echristo edited edge metadata.

LGTM.

Motivation: Fewer processes spawned for tests, this is particularly good on OSes that have slow forking code like OSX and Windows. Easier to find "what are the tests that are associated with this feature". I'm sure if you think about it you can probably come up with a few more. :)

This revision is now accepted and ready to land.Nov 16 2015, 2:59 PM

If launching less processes is a motivation, then not adding FileCheck when not needing (crash test) should be good practice :)

In D14733#290586, @joker.eph wrote:

If launching less processes is a motivation, then not adding FileCheck when not needing (crash test) should be good practice :)

Nope. Because you should have a check for some sort of reasonable behavior if possible. :)

This revision was automatically updated to reflect the committed changes.