This is an archive of the discontinued LLVM Phabricator instance.

Differential D147124

[lld][ELF][NFC] Simplify "Thunk *elf::addThunk()"
ClosedPublic

Authored by benshi001 on Mar 29 2023, 1:43 AM.

Details

Reviewers
MaskRay
Commits
rGf1f6ca582e22: [lld][ELF][NFC] Simplify method "Thunk *elf::addThunk()"

Diff Detail

Event Timeline

benshi001 created this revision.Mar 29 2023, 1:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2023, 1:43 AM
Herald added subscribers: arichardson, emaste. · View Herald Transcript
benshi001 requested review of this revision.Mar 29 2023, 1:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 29 2023, 1:43 AM
Herald added subscribers: llvm-commits, jacquesguan. · View Herald Transcript
benshi001 retitled this revision from [lld][ELF][NFC] Simplify "Thunk *elf::addThunk(...)" to [lld][ELF][NFC] Simplify "Thunk *elf::addThunk()".Mar 29 2023, 2:09 AM
Harbormaster completed remote builds in B222438: Diff 509251.Mar 29 2023, 6:16 AM
MaskRay accepted this revision.Mar 29 2023, 8:09 PM
MaskRay added inline comments.
lld/ELF/Thunks.cpp
1318–1319

You can delete the blank lines between two labels.

This revision is now accepted and ready to land.Mar 29 2023, 8:09 PM
benshi001 marked an inline comment as done.Mar 29 2023, 8:25 PM
benshi001 added inline comments.
lld/ELF/Thunks.cpp
1318–1319

OK. I will do when committing.

benshi001 marked an inline comment as done.Mar 29 2023, 8:26 PM
Closed by commit rGf1f6ca582e22: [lld][ELF][NFC] Simplify method "Thunk *elf::addThunk()" (authored by benshi001). · Explain WhyMar 29 2023, 8:35 PM
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rGf1f6ca582e22: [lld][ELF][NFC] Simplify method "Thunk *elf::addThunk()".

Revision Contents

PathSize
lld/
ELF/
20 lines

Diff 509542

lld/ELF/Thunks.cpp

Show First 20 Lines • Show All 1,307 Lines • ▼ Show 20 Linesstatic Thunk *addThunkPPC64(RelType type, Symbol &s, int64_t a) {
return make<PPC64PDLongBranchThunk>(s, a); return make<PPC64PDLongBranchThunk>(s, a);
} }
Thunk *elf::addThunk(const InputSection &isec, Relocation &rel) { Thunk *elf::addThunk(const InputSection &isec, Relocation &rel) {
Symbol &s = *rel.sym; Symbol &s = *rel.sym;
int64_t a = rel.addend; int64_t a = rel.addend;
if (config->emachine == EM_AARCH64) switch (config->emachine) {
case EM_AARCH64:
return addThunkAArch64(rel.type, s, a); return addThunkAArch64(rel.type, s, a);
case EM_ARM:
MaskRayUnsubmitted
Done
ReplyInline Actions

You can delete the blank lines between two labels.

MaskRay: You can delete the blank lines between two labels.
benshi001AuthorUnsubmitted
Done
ReplyInline Actions

OK. I will do when committing.

benshi001: OK. I will do when committing.
if (config->emachine == EM_ARM)
return addThunkArm(rel.type, s, a); return addThunkArm(rel.type, s, a);
case EM_MIPS:
if (config->emachine == EM_MIPS)
return addThunkMips(rel.type, s); return addThunkMips(rel.type, s);
case EM_PPC:
if (config->emachine == EM_PPC)
return addThunkPPC32(isec, rel, s); return addThunkPPC32(isec, rel, s);
case EM_PPC64:
if (config->emachine == EM_PPC64)
return addThunkPPC64(rel.type, s, a); return addThunkPPC64(rel.type, s, a);
default:
llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC"); llvm_unreachable("add Thunk only supported for ARM, Mips and PowerPC");
} }
}