This is an archive of the discontinued LLVM Phabricator instance.

Differential D147094

[fuzzer] Limit big-file-copy.test to darwin only
ClosedPublic

Authored by rsundahl on Mar 28 2023, 4:12 PM.

Details

Reviewers
yln
thetruestblue
wrotki
NoQ
Commits
rG4c55fd974b9f: [fuzzer] Limit big-file-copy.test to darwin only
Summary

This test has to be limited to darwin due to multiple failures on other
platforms for multple reasons. (Timeout, puts() limit, etc.). This
commit modifies D146189.

Diff Detail

Event Timeline

rsundahl created this revision.Mar 28 2023, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 4:12 PM
Herald added a subscriber: Enna1. · View Herald Transcript
rsundahl requested review of this revision.Mar 28 2023, 4:12 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 28 2023, 4:12 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl mentioned this in D146189: [fuzzer] Use puts() rather than printf() in CopyFileToErr().Mar 28 2023, 4:13 PM
rsundahl added reviewers: yln, thetruestblue, wrotki.Mar 28 2023, 4:15 PM
Harbormaster completed remote builds in B222370: Diff 509164.Mar 28 2023, 4:30 PM
rsundahl added a reviewer: dergachev.a.Mar 28 2023, 5:09 PM
NoQ edited reviewers, added: NoQ; removed: dergachev.a.Mar 28 2023, 5:11 PM
NoQ added inline comments.
compiler-rt/test/fuzzer/big-file-copy.test
2

A quick grep suggests that this should say REQUIRES: system-darwin.

NoQ accepted this revision.Mar 28 2023, 5:22 PM
NoQ added inline comments.
compiler-rt/test/fuzzer/big-file-copy.test
2

Hmm, looks like clang uses system-darwin but compiler-rt uses darwin. Probably both are fine, given that it's the same LIT under the hood. Or maybe they define it differently in lit config 🤔 In any case LGTM then!

This revision is now accepted and ready to land.Mar 28 2023, 5:22 PM
Closed by commit rG4c55fd974b9f: [fuzzer] Limit big-file-copy.test to darwin only (authored by rsundahl). · Explain WhyMar 28 2023, 5:23 PM
This revision was automatically updated to reflect the committed changes.
rsundahl added a commit: rG4c55fd974b9f: [fuzzer] Limit big-file-copy.test to darwin only.
NoQ added inline comments.Mar 28 2023, 5:27 PM
compiler-rt/test/fuzzer/big-file-copy.test
2

compiler-rt/test/fuzzer/lit.cfg.py:

47 if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
48   config.available_features.add('windows')
49
50 if sys.platform.startswith('darwin'):
51   config.available_features.add('darwin')

Looks like this is a libfuzzer-specific item in available_features (which may or may not have a slightly different meaning).

rsundahl mentioned this in D147502: [fuzzer][test] Avoid big-file-copy.test on memory constrained devices.Apr 4 2023, 5:49 AM
rsundahl mentioned this in rG5c950a3127da: [fuzzer][test] Avoid big-file-copy.test on memory constrained devices.Apr 4 2023, 11:03 AM

Revision Contents

PathSize
compiler-rt/
test/
fuzzer/
1 line

Diff 509178

compiler-rt/test/fuzzer/big-file-copy.test

REQUIRES: darwin
RUN: %cpp_compiler %S/BigFileCopy.cpp -o %t RUN: %cpp_compiler %S/BigFileCopy.cpp -o %t
NoQUnsubmitted
Not Done
ReplyInline Actions

A quick grep suggests that this should say REQUIRES: system-darwin.

NoQ: A quick grep suggests that this should say `REQUIRES: system-darwin`.
NoQUnsubmitted
Not Done
ReplyInline Actions

Hmm, looks like clang uses system-darwin but compiler-rt uses darwin. Probably both are fine, given that it's the same LIT under the hood. Or maybe they define it differently in lit config 🤔 In any case LGTM then!

NoQ: Hmm, looks like `clang` uses `system-darwin` but `compiler-rt` uses `darwin`. Probably both are…
NoQUnsubmitted
Not Done
ReplyInline Actions

compiler-rt/test/fuzzer/lit.cfg.py:

47 if sys.platform.startswith('win') or sys.platform.startswith('cygwin'):
48   config.available_features.add('windows')
49
50 if sys.platform.startswith('darwin'):
51   config.available_features.add('darwin')

Looks like this is a libfuzzer-specific item in available_features (which may or may not have a slightly different meaning).

NoQ: `compiler-rt/test/fuzzer/lit.cfg.py`: ``` 47 if sys.platform.startswith('win') or sys.
RUN: %run %t -runs=1 -rss_limit_mb=4096 2>big-file-out.txt; result=$? RUN: %run %t -runs=1 -rss_limit_mb=4096 2>big-file-out.txt; result=$?
RUN: %run rm -f big-file.txt big-file-out.txt RUN: %run rm -f big-file.txt big-file-out.txt
RUN: %run (exit $result) RUN: %run (exit $result)