This is an archive of the discontinued LLVM Phabricator instance.

[fuzzer][test] Avoid big-file-copy.test on memory constrained devices
ClosedPublic

Authored by rsundahl on Apr 3 2023, 10:15 PM.

Details

Summary

The test "big-file-copy.test" introduced in D146189 and constrained to darwin by
D147094, is by this differential further constrained to only those devices with
sufficient resources. Also correct the test to read the environment variable
"result" from the same shell in which it was stored (which may differ on devices).

Diff Detail

Event Timeline

rsundahl created this revision.Apr 3 2023, 10:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2023, 10:15 PM
Herald added a subscriber: Enna1. · View Herald Transcript
rsundahl requested review of this revision.Apr 3 2023, 10:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 3 2023, 10:15 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rsundahl updated this revision to Diff 510693.Apr 3 2023, 10:18 PM

Update title and add Radar reference.

rsundahl retitled this revision from [sanitizer][test] Fix big-file-copy.test on devices. Disable test on tvOS to [sanitizer][test] Fix big-file-copy.test on device..Apr 3 2023, 10:21 PM
rsundahl edited the summary of this revision. (Show Details)
rsundahl updated this revision to Diff 510761.Apr 4 2023, 5:45 AM
rsundahl edited the summary of this revision. (Show Details)

Change to improve title and summary.

rsundahl retitled this revision from [sanitizer][test] Fix big-file-copy.test on device. to [fuzzer][test] Avoid big-file-copy.test on memory constrained devices.Apr 4 2023, 5:49 AM
rsundahl edited the summary of this revision. (Show Details)
rsundahl edited the summary of this revision. (Show Details)
thetruestblue added inline comments.Apr 4 2023, 8:14 AM
compiler-rt/test/fuzzer/big-file-copy.test
2

This is redundant. ios lit feature includes all ios derivatives:

# =========================================================================
# Target             | Feature set
# =========================================================================
# macOS              | darwin
# iOS device         | darwin, ios
# iOS simulator      | darwin, ios, iossim
# tvOS device        | darwin, ios, tvos
# tvOS simulator     | darwin, ios, iossim, tvos, tvossim
# watchOS device     | darwin, ios, watchos
# watchOS simulator  | darwin, ios, iossim, watchos, watchossim
# =========================================================================
rsundahl added inline comments.Apr 4 2023, 8:42 AM
compiler-rt/test/fuzzer/big-file-copy.test
2

Thank you! I meant to restrict tvOS and watchOS, not all iOS. I'll retest with the change and update.

rsundahl updated this revision to Diff 510830.Apr 4 2023, 9:03 AM
rsundahl edited the summary of this revision. (Show Details)

ios->tvos

rsundahl marked an inline comment as done.Apr 4 2023, 9:04 AM
rsundahl added inline comments.
compiler-rt/test/fuzzer/big-file-copy.test
2

Updated to reflect that test should be active on iOS and derivatives other than tvOS and watchOS.

thetruestblue accepted this revision.Apr 4 2023, 9:27 AM
This revision is now accepted and ready to land.Apr 4 2023, 9:27 AM