Page MenuHomePhabricator
Differential D146895

[clang-format] Don't annotate left brace of struct as FunctionLBrace
ClosedPublic
Actions

Authored by owenpan on Mar 25 2023, 7:51 PM.

Details

Reviewers
MyDeveloperDay
HazardyKnusperkeks
rymiel
Commits
rG767aee1de9e9: [clang-format] Don't annotate left brace of struct as FunctionLBrace
Summary

Related to a02c3af9f19d. Fixes https://github.com/llvm/llvm-project/issues/61700.

Diff Detail

Event Timeline

owenpan created this revision.Mar 25 2023, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 7:51 PM
owenpan requested review of this revision.Mar 25 2023, 7:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 25 2023, 7:51 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B221794: Diff 508369.Mar 26 2023, 3:19 AM
MyDeveloperDay accepted this revision.Mar 26 2023, 8:44 AM

LGTM

This revision is now accepted and ready to land.Mar 26 2023, 8:44 AM
owenpan updated this revision to Diff 508464.Mar 26 2023, 8:03 PM

Handles consecutive attributes too.

owenpan requested review of this revision.Mar 26 2023, 8:03 PM
MyDeveloperDay accepted this revision.Mar 27 2023, 1:35 AM
This revision is now accepted and ready to land.Mar 27 2023, 1:35 AM
Harbormaster completed remote builds in B221871: Diff 508464.Mar 27 2023, 12:43 PM
This revision was landed with ongoing or failed builds.Mar 27 2023, 2:07 PM
Closed by commit rG767aee1de9e9: [clang-format] Don't annotate left brace of struct as FunctionLBrace (authored by owenpan). · Explain Why
This revision was automatically updated to reflect the committed changes.
owenpan added a commit: rG767aee1de9e9: [clang-format] Don't annotate left brace of struct as FunctionLBrace.

Revision Contents
Changeset List

PathSize
clang/
lib/
Format/
26 lines
unittests/
Format/
5 lines
8 lines

Diff 508791

View Options

clang/lib/Format/UnwrappedLineParser.cpp

Loading...
View Options

clang/unittests/Format/FormatTest.cpp

Loading...
View Options

clang/unittests/Format/TokenAnnotatorTest.cpp

Loading...