Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D146671

[clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id
ClosedPublic
Actions

Authored by chaitanyav on Mar 22 2023, 4:41 PM.

Details

Reviewers
dang
ributzka
zixuw
Commits
rGc13ccf1fbabe: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type…
Summary

Fixes https://github.com/llvm/llvm-project/issues/61481

Diff Detail

Event Timeline

chaitanyav created this revision.Mar 22 2023, 4:41 PM
Herald added a reviewer: ributzka. · View Herald TranscriptMar 22 2023, 4:41 PM
Herald added a project: Restricted Project. · View Herald Transcript
chaitanyav requested review of this revision.Mar 22 2023, 4:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 4:41 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
chaitanyav retitled this revision from Fix Declaration fragments for instancetype in the type position degrade to id to [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type position degrade to id.Mar 22 2023, 4:57 PM
Harbormaster completed remote builds in B221170: Diff 507548.Mar 22 2023, 10:21 PM
dang added a reviewer: zixuw.Mar 23 2023, 4:24 AM
dang accepted this revision.Mar 23 2023, 4:43 AM

LGTM, but you should also check in the test that id still renders as expected.

This revision is now accepted and ready to land.Mar 23 2023, 4:43 AM
chaitanyav added a comment.Mar 23 2023, 5:24 AM

Will update the test to also include a Id instance method.

chaitanyav updated this revision to Diff 507725.Mar 23 2023, 6:41 AM

update test to check for id type

Harbormaster completed remote builds in B221303: Diff 507725.Mar 23 2023, 7:54 AM
chaitanyav added a comment.Mar 23 2023, 8:10 AM

@dang Please review the test/output.

dang accepted this revision.Mar 23 2023, 8:13 AM

Yup looks fine to me!

This revision was landed with ongoing or failed builds.Mar 23 2023, 3:11 PM
Closed by commit rGc13ccf1fbabe: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type… (authored by chaitanyav). · Explain Why
This revision was automatically updated to reflect the committed changes.
chaitanyav added a commit: rGc13ccf1fbabe: [clang][ExtractAPI]Fix Declaration fragments for instancetype in the type….

Revision Contents
Changeset List

PathSize
clang/
lib/
ExtractAPI/
22 lines
test/
ExtractAPI/
254 lines

Diff 507892

View Options

clang/lib/ExtractAPI/DeclarationFragments.cpp

Loading...
View Options

clang/test/ExtractAPI/objc_instancetype.m

Loading...