This is an archive of the discontinued LLVM Phabricator instance.

Differential D146551

[libc] Re-enable wctob with fixes
ClosedPublic

Authored by michaelrj on Mar 21 2023, 11:15 AM.

Details

Reviewers
sivachandra
Commits
rGe0de24cb0d55: [libc] Re-enable wctob with fixes
Summary

The stdio test failures were due to headers potentially not being built
in the correct order. This should set up the dependencies correctly.

Diff Detail

Event Timeline

michaelrj created this revision.Mar 21 2023, 11:15 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 21 2023, 11:15 AM
Herald added subscribers: libc-commits, mikhail.ramalho, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Mar 21 2023, 11:15 AM
Harbormaster completed remote builds in B220784: Diff 507063.Mar 21 2023, 11:40 AM
sivachandra accepted this revision.Mar 24 2023, 10:32 AM
sivachandra added inline comments.
libc/include/CMakeLists.txt
187

This dep should be added to llvm-libc-types.cookie_io_functions_t also.

This revision is now accepted and ready to land.Mar 24 2023, 10:32 AM
michaelrj updated this revision to Diff 509424.Mar 29 2023, 11:11 AM
michaelrj marked an inline comment as done.

add ssize_t dependency to cookie_io_functions_t

michaelrj updated this revision to Diff 509428.Mar 29 2023, 11:22 AM

reorder type headers in cmake to fix "missing type ssize_t" error

Harbormaster completed remote builds in B222564: Diff 509428.Mar 29 2023, 11:34 AM
Closed by commit rGe0de24cb0d55: [libc] Re-enable wctob with fixes (authored by michaelrj). · Explain WhyMar 29 2023, 12:49 PM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rGe0de24cb0d55: [libc] Re-enable wctob with fixes.

Revision Contents

PathSize
libc/
config/
linux/
x86_64/
2 lines
include/
1 line
llvm-libc-types/
2 lines
src/
wchar/
1 line

Diff 509424

libc/config/linux/x86_64/entrypoints.txt

Show First 20 Lines • Show All 189 Lines • ▼ Show 20 Linesset(TARGET_LIBC_ENTRYPOINTS
libc.src.unistd.symlinkat libc.src.unistd.symlinkat
libc.src.unistd.sysconf libc.src.unistd.sysconf
libc.src.unistd.truncate libc.src.unistd.truncate
libc.src.unistd.unlink libc.src.unistd.unlink
libc.src.unistd.unlinkat libc.src.unistd.unlinkat
libc.src.unistd.write libc.src.unistd.write
# wchar.h entrypoints # wchar.h entrypoints
# libc.src.wchar.wctob libc.src.wchar.wctob
) )
set(TARGET_LIBM_ENTRYPOINTS set(TARGET_LIBM_ENTRYPOINTS
# fenv.h entrypoints # fenv.h entrypoints
libc.src.fenv.feclearexcept libc.src.fenv.feclearexcept
libc.src.fenv.fedisableexcept libc.src.fenv.fedisableexcept
libc.src.fenv.feenableexcept libc.src.fenv.feenableexcept
libc.src.fenv.fegetenv libc.src.fenv.fegetenv
▲ Show 20 Lines • Show All 307 Lines • Show Last 20 Lines

libc/include/CMakeLists.txt

Show First 20 Lines • Show All 178 Lines • ▼ Show 20 Linesadd_gen_header(
stdio stdio
DEF_FILE stdio.h.def DEF_FILE stdio.h.def
GEN_HDR stdio.h GEN_HDR stdio.h
DEPENDS DEPENDS
.llvm_libc_common_h .llvm_libc_common_h
.llvm-libc-macros.file_seek_macros .llvm-libc-macros.file_seek_macros
.llvm-libc-macros.stdio_macros .llvm-libc-macros.stdio_macros
.llvm-libc-types.size_t .llvm-libc-types.size_t
.llvm-libc-types.ssize_t
sivachandraUnsubmitted
Done
ReplyInline Actions

This dep should be added to llvm-libc-types.cookie_io_functions_t also.

sivachandra: This dep should be added to `llvm-libc-types.cookie_io_functions_t` also.
.llvm-libc-types.FILE .llvm-libc-types.FILE
.llvm-libc-types.cookie_io_functions_t .llvm-libc-types.cookie_io_functions_t
) )
add_gen_header( add_gen_header(
stdlib stdlib
DEF_FILE stdlib.h.def DEF_FILE stdlib.h.def
GEN_HDR stdlib.h GEN_HDR stdlib.h
▲ Show 20 Lines • Show All 323 Lines • Show Last 20 Lines

libc/include/llvm-libc-types/CMakeLists.txt

Show All 13 Lines
add_header(__sighandler_t HDR __sighandler_t.h) add_header(__sighandler_t HDR __sighandler_t.h)
add_header(__thread_type HDR __thread_type.h) add_header(__thread_type HDR __thread_type.h)
add_header(blkcnt_t HDR blkcnt_t.h) add_header(blkcnt_t HDR blkcnt_t.h)
add_header(blksize_t HDR blksize_t.h) add_header(blksize_t HDR blksize_t.h)
add_header(cc_t HDR cc_t.h) add_header(cc_t HDR cc_t.h)
add_header(clock_t HDR clock_t.h) add_header(clock_t HDR clock_t.h)
add_header(clockid_t HDR clockid_t.h) add_header(clockid_t HDR clockid_t.h)
add_header(cnd_t HDR cnd_t.h) add_header(cnd_t HDR cnd_t.h)
add_header(cookie_io_functions_t HDR cookie_io_functions_t.h DEPENDS .off64_t) add_header(cookie_io_functions_t HDR cookie_io_functions_t.h DEPENDS .off64_t .ssize_t)
add_header(cpu_set_t HDR cpu_set_t.h) add_header(cpu_set_t HDR cpu_set_t.h)
add_header(double_t HDR double_t.h) add_header(double_t HDR double_t.h)
add_header(DIR HDR DIR.h) add_header(DIR HDR DIR.h)
add_header(dev_t HDR dev_t.h) add_header(dev_t HDR dev_t.h)
add_header(div_t HDR div_t.h) add_header(div_t HDR div_t.h)
add_header(ldiv_t HDR ldiv_t.h) add_header(ldiv_t HDR ldiv_t.h)
add_header(lldiv_t HDR lldiv_t.h) add_header(lldiv_t HDR lldiv_t.h)
add_header(FILE HDR FILE.h) add_header(FILE HDR FILE.h)
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines

libc/src/wchar/CMakeLists.txt

add_entrypoint_object( add_entrypoint_object(
wctob wctob
SRCS SRCS
wctob.cpp wctob.cpp
HDRS HDRS
wctob.h wctob.h
DEPENDS DEPENDS
libc.include.stdio libc.include.stdio
libc.include.wchar
libc.src.__support.wctype_utils libc.src.__support.wctype_utils
) )