This is an archive of the discontinued LLVM Phabricator instance.

[tsan] Add more interface functions into tsan_interface.h
Changes PlannedPublic

Authored by vitalybuka on Mar 20 2023, 4:22 PM.

Details

Diff Detail

Event Timeline

vitalybuka created this revision.Mar 20 2023, 4:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 4:22 PM
Herald added a subscriber: Enna1. · View Herald Transcript
vitalybuka requested review of this revision.Mar 20 2023, 4:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 4:22 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
dvyukov added inline comments.Mar 21 2023, 1:12 AM
compiler-rt/lib/tsan/rtl/tsan_interface.h
40

I don't think we want these test-only interfaces here.
That's just an implementation detail for unit-tests. There are also:

__tsan_testonly_barrier_init
__tsan_testonly_barrier_wait
__tsan_testonly_shadow_stack_current_size

But we don't want any external users to depend on them.
E.g. at least to rename them consistently to "test_only" or "testonly" :)

vitalybuka planned changes to this revision.Mar 21 2023, 9:37 AM
vitalybuka added inline comments.
compiler-rt/lib/tsan/rtl/tsan_interface.h
40

yes, that's probably me readin prefix and suffix and missed the "test"