Page MenuHomePhabricator
Differential D146365

[libc++] Also support target triples that end with .0 in backdeployment tests
AcceptedPublic
Actions

Authored by ldionne on Sat, Mar 18, 1:27 PM.

Details

Reviewers
Mordante
Group Reviewers
Restricted Project
Summary

Sometimes, a target can look like <arch>-apple-macosx10.15.0 instead
of <arch>-apple-macosx10.15. This ensures that the test suite handles
those target triples properly as well.

Diff Detail

Event Timeline

ldionne created this revision.Sat, Mar 18, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 18, 1:27 PM
Herald added subscribers: mikhail.ramalho, arichardson. · View Herald Transcript
ldionne requested review of this revision.Sat, Mar 18, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptSat, Mar 18, 1:27 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
ldionne added a parent revision: D146359: [libc++] Use named Lit features to flag back-deployment XFAILs.Sat, Mar 18, 1:27 PM
Harbormaster completed remote builds in B220236: Diff 506314.Sat, Mar 18, 1:27 PM
ldionne added a child revision: D146366: [libc++] Use the stdlib=<LIB> Lit feature instead of use_system_cxx_lib.Sat, Mar 18, 1:31 PM
ldionne updated this revision to Diff 506316.Sat, Mar 18, 1:35 PM

Re-upload with parent to trigger CI properly.

Harbormaster completed remote builds in B220238: Diff 506316.Sat, Mar 18, 3:37 PM
Mordante accepted this revision.Sun, Mar 19, 11:18 AM
Mordante added a subscriber: Mordante.

Just curious, but why not squash D146365 and D146359? It seems this patch only modifies the previous patch in the stack.

I've no strong objection against two patches, LGTM.

This revision is now accepted and ready to land.Sun, Mar 19, 11:18 AM

Revision Contents
Changeset List

PathSize
libcxx/
utils/
libcxx/
test/
22 lines

Diff 506314

View Options

libcxx/utils/libcxx/test/features.py

Loading...