This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Also support target triples that end with .0 in backdeployment tests
ClosedPublic

Authored by ldionne on Mar 18 2023, 1:27 PM.

Details

Summary

Sometimes, a target can look like <arch>-apple-macosx10.15.0 instead
of <arch>-apple-macosx10.15. This ensures that the test suite handles
those target triples properly as well.

Diff Detail

Event Timeline

ldionne created this revision.Mar 18 2023, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2023, 1:27 PM
ldionne requested review of this revision.Mar 18 2023, 1:27 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 18 2023, 1:27 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne updated this revision to Diff 506316.Mar 18 2023, 1:35 PM

Re-upload with parent to trigger CI properly.

Mordante accepted this revision.Mar 19 2023, 11:18 AM
Mordante added a subscriber: Mordante.

Just curious, but why not squash D146365 and D146359? It seems this patch only modifies the previous patch in the stack.

I've no strong objection against two patches, LGTM.

This revision is now accepted and ready to land.Mar 19 2023, 11:18 AM

Just curious, but why not squash D146365 and D146359? It seems this patch only modifies the previous patch in the stack.

I've no strong objection against two patches, LGTM.

Oh, it's just that I wanted D146359 not to have any semantic changes since it was already a large mechanical diff.

ldionne updated this revision to Diff 508707.Mar 27 2023, 9:47 AM

Rebase to trigger CI.