[InstCombine] Add tests for indirect mul by power of 2; NFC
AcceptedPublic
Actions

Authored by goldstein.w.n on Fri, Mar 17, 7:04 PM.

Details

Reviewers

nikic
spatel
majnemer

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	240 ms	x64 debian > Flang.Driver::code-gen-rv64.f90 Script: -- : 'RUN: at line 5'; rm -f /var/lib/buildkite-agent/builds/llvm-project/build/tools/flang/test/Driver/Output/code-gen-rv64.f90.tmp.o
	100 ms	x64 debian > MLIR.Target/LLVMIR::llvmir-intrinsics.mlir Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/mlir-translate -mlir-to-llvmir /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir

Event Timeline

goldstein.w.n created this revision.Fri, Mar 17, 7:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 7:04 PM

goldstein.w.n requested review of this revision.Fri, Mar 17, 7:04 PM

Herald added a project: Restricted Project. · View Herald TranscriptFri, Mar 17, 7:04 PM

Herald added a subscriber: llvm-commits. · View Herald Transcript

goldstein.w.n retitled this revision from Add tests for indirect mul by power of 2; NFC to [InstCombine] Add tests for indirect mul by power of 2; NFC.Fri, Mar 17, 7:05 PM

goldstein.w.n added reviewers: nikic, spatel, majnemer.

Herald added a subscriber: StephenFan. · View Herald TranscriptFri, Mar 17, 7:05 PM

goldstein.w.n added a child revision: D146347: [InstCombine] Improve transforms for `(mul X, Y)` -> `(shl X, log2(Y)`.Fri, Mar 17, 7:05 PM

Harbormaster completed remote builds in B220190: Diff 506256.Fri, Mar 17, 7:28 PM

nikic added inline comments.Sat, Mar 18, 4:55 AM

llvm/test/Transforms/InstCombine/mul-pow2.ll
63	Missing a commuted test -- everything here gets canonicalized to `mul s, x`. Also missing a multi-use test. This is going to fail (as in, perform an unprofitable transform) due to open FIXMEs in takeLog2(), but we should at least highlight that the problem exists.

Put tests in canonical commuted form. Add multiuse tests

goldstein.w.n marked an inline comment as done.Sat, Mar 18, 1:53 PM

Add flag propegation test

LGTM

This revision is now accepted and ready to land.Sat, Mar 18, 2:19 PM

Harbormaster completed remote builds in B220248: Diff 506327.Sat, Mar 18, 2:49 PM

Revision Contents
Changeset List

Path

Size

llvm/

test/

Transforms/

InstCombine/

mul-pow2.ll

63 lines

Diff 506256

View Options

llvm/test/Transforms/InstCombine/mul-pow2.ll

[InstCombine] Add tests for indirect mul by power of 2; NFCAcceptedPublicActions