Paths

Table of Contentst

[libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests
ClosedPublic
Actions

Authored by ldionne on Thu, Mar 16, 9:52 AM.

Details

Reviewers

philnik
Mordante

Group Reviewers

Restricted Project

Commits

rG72f0edf3f429: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.

Summary

We pretty consistently don't define those cause they are not needed,
and it removes the potential pitfall to think that these tests are
being run. This doesn't touch .compile.fail.cpp tests since those
should be replaced by .verify.cpp tests anyway, and there would be
a lot to fix up.

As a fly-by, I also fixed a bit of formatting, removed a few unused
includes and made some very minor, clearly NFC refactorings such as
in allocator.traits/allocator.traits.members/allocate.verify.cpp where
the old test basically made no sense the way it was written.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

ldionne created this revision.Thu, Mar 16, 9:52 AM

Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 9:52 AM

Herald added a subscriber: mikhail.ramalho. · View Herald Transcript

ldionne requested review of this revision.Thu, Mar 16, 9:52 AM

Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 16, 9:52 AM

Herald added a reviewer: Restricted Project. · View Herald Transcript

Herald added a subscriber: libcxx-commits. · View Herald Transcript

LGTM with green CI.

This revision is now accepted and ready to land.Thu, Mar 16, 10:03 AM

LGTM, did you also verify the verify and fail tests? If not, then that would be nice as a followup.

Harbormaster completed remote builds in B219901: Diff 505850.Thu, Mar 16, 11:30 AM

In D146236#4200028, @Mordante wrote:

LGTM, did you also verify the verify and fail tests? If not, then that would be nice as a followup.

I'll do it for .verify.cpp tests too, however .compile.fail.cpp tests should move to .verify and there's a lot of them, so I'd rather tackle that separately (if at all for the time being).

Also tackle .verify.cpp tests

Harbormaster completed remote builds in B220069: Diff 506089.Fri, Mar 17, 9:39 AM

The no-exceptions configuration is failing due to a clang bug that Mark is still bisecting AFAIK, so this is green.

This revision was landed with ongoing or failed builds.Fri, Mar 17, 2:56 PM

Closed by commit rG72f0edf3f429: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify. (authored by ldionne). · Explain Why

This revision was automatically updated to reflect the committed changes.

ldionne added a commit: rG72f0edf3f429: [libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify..

Large Diff

This large diff affects 138 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

Path

Size

libcxx/

test/

libcxx/

algorithms/

alg.modifying.operations/

alg.random.shuffle/

random_shuffle.depr_in_cxx14.verify.cpp

5 lines

atomics/

bit-int.verify.cpp

5 lines

diagnose_invalid_memory_order.verify.cpp

4 lines

containers/

associative/

non_const_comparator.incomplete.verify.cpp

7 lines

non_const_comparator.verify.cpp

4 lines

unord/

non_const_comparator.incomplete.verify.cpp

4 lines

non_const_comparator.verify.cpp

4 lines

depr/

depr.auto.ptr/

auto.ptr/

auto_ptr.depr_in_cxx11.verify.cpp

11 lines

depr.default.allocator/

allocator.members/

address.depr_in_cxx17.verify.cpp

9 lines

allocate.cxx2a.verify.cpp

8 lines

allocate.depr_in_cxx17.verify.cpp

6 lines

depr.function.objects/

adaptors.depr_in_cxx11.verify.cpp

6 lines

diagnostics/

nodiscard_aftercxx17.verify.cpp

5 lines

nodiscard_extensions.compile.pass.cpp

4 lines

nodiscard_extensions.verify.cpp

4 lines

iterators/

predef.iterators/

__unconstrained_reverse_iterator/

reverse.iter.cons/

ctor.iter.explicit.verify.cpp

3 lines

reverse.iterators/

bad_template_argument.verify.cpp

4 lines

language.support/

support.dynamic/

aligned_alloc_availability.verify.cpp

3 lines

numerics/

rand/

rand.device/

has-no-random-device.verify.cpp

3 lines

ranges/

version.compile.pass.cpp

3 lines

selftest/

verify.cpp/

no-werror.verify.cpp

3 lines

thread/

atomic.availability.verify.cpp

5 lines

barrier.availability.verify.cpp

4 lines

latch.availability.verify.cpp

5 lines

semaphore.availability.verify.cpp

5 lines

thread.barrier/

version.compile.pass.cpp

5 lines

thread.latch/

version.compile.pass.cpp

5 lines

thread.lock/

thread.lock.guard/

nodiscard.verify.cpp

3 lines

thread.semaphore/

version.compile.pass.cpp

5 lines

utilities/

format/

version.compile.pass.cpp

3 lines

std/

atomics/

atomics.types.generic/

standard_layout.compile.pass.cpp

4 lines

atomics.types.operations/

atomics.types.operations.req/

copy.assign.ptr.volatile.verify.cpp

3 lines

copy.assign.volatile.verify.cpp

3 lines

concepts/

concepts.compare/

concept.equalitycomparable/

equality_comparable.compile.pass.cpp

2 lines

equality_comparable_with.compile.pass.cpp

2 lines

concepts.lang/

concept.common/

common_with.compile.pass.cpp

2 lines

concept.commonref/

common_reference.compile.pass.cpp

2 lines

concept.constructible/

constructible_from.compile.pass.cpp

2 lines

concept.copyconstructible/

copy_constructible.compile.pass.cpp

2 lines

concept.default.init/

default_initializable.compile.pass.cpp

5 lines

default_initializable.verify.cpp

6 lines

concept.destructible/

destructible.compile.pass.cpp

3 lines

concept.moveconstructible/

move_constructible.compile.pass.cpp

2 lines

concepts.object/

copyable.compile.pass.cpp

2 lines

movable.compile.pass.cpp

2 lines

regular.compile.pass.cpp

2 lines

semiregular.compile.pass.cpp

2 lines

containers/

associative/

map/

map.access/

empty.verify.cpp

7 lines

multimap/

empty.verify.cpp

7 lines

multiset/

empty.verify.cpp

7 lines

set/

empty.verify.cpp

7 lines

container.adaptors/

priority.queue/

priqueue.members/

empty.verify.cpp

7 lines

queue/

queue.defn/

empty.verify.cpp

7 lines

stack/

stack.defn/

empty.verify.cpp

7 lines

sequences/

array/

empty.verify.cpp

8 lines

deque/

deque.capacity/

empty.verify.cpp

7 lines

forwardlist/

empty.verify.cpp

7 lines

list/

list.capacity/

empty.verify.cpp

7 lines

vector.bool/

empty.verify.cpp

7 lines

vector/

vector.capacity/

empty.verify.cpp

7 lines

vector.cons/

copy.move_only.verify.cpp

4 lines

unord/

unord.map/

empty.verify.cpp

7 lines

unord.multimap/

empty.verify.cpp

7 lines

unord.multiset/

empty.verify.cpp

7 lines

unord.set/

empty.verify.cpp

7 lines

views/

views.span/

span.cons/

iterator_len.verify.cpp

4 lines

iterator_sentinel.verify.cpp

5 lines

depr/

depr.lib.binders/

depr.lib.bind.1st/

bind1st.depr_in_cxx11.verify.cpp

6 lines

depr.lib.bind.2nd/

bind2nd.depr_in_cxx11.verify.cpp

6 lines

depr.lib.binder.1st/

binder1st.depr_in_cxx11.verify.cpp

8 lines

depr.lib.binder.2nd/

binder2nd.depr_in_cxx11.verify.cpp

8 lines

input.output/

filesystems/

class.path/

path.member/

path.decompose/

empty.verify.cpp

7 lines

iostream.format/

quoted.manip/

quoted_char.verify.cpp

5 lines

quoted_traits.verify.cpp

5 lines

iterators/

iterator.container/

empty.array.verify.cpp

8 lines

empty.container.verify.cpp

7 lines

empty.initializer_list.verify.cpp

7 lines

iterator.requirements/

iterator.cust/

iterator.cust.move/

iter_move.nodiscard.verify.cpp

4 lines

predef.iterators/

move.iterators/

move.iter.ops/

move.iter.op.const/

ctor.iter.explicit.verify.cpp

3 lines

move.iter.op.ref/

deprecated.verify.cpp

7 lines

reverse.iterators/

reverse.iter.cons/

ctor.iter.explicit.verify.cpp

3 lines

language.support/

cmp/

cmp.categories.pre/

zero_type.verify.cpp

3 lines

support.dynamic/

new.delete/

new.delete.array/

new_size.verify.cpp

3 lines

new_size_align.verify.cpp

3 lines

new_size_align_nothrow.verify.cpp

3 lines

new_size_nothrow.verify.cpp

3 lines

new.delete.placement/

new_array_ptr.verify.cpp

7 lines

new_ptr.verify.cpp

7 lines

new.delete.single/

new_size.verify.cpp

7 lines

new_size_align.verify.cpp

3 lines

new_size_align_nothrow.verify.cpp

3 lines

new_size_nothrow.verify.cpp

7 lines

ptr.launder/

launder.nodiscard.verify.cpp

10 lines

localization/

locale.categories/

category.ctype/

locale.codecvt.byname/

codecvt_byname_char16_t_char.depr_in_cxx20.verify.cpp

6 lines

codecvt_byname_char32_t_char.depr_in_cxx20.verify.cpp

6 lines

locale.codecvt/

codecvt_char16_t_char.depr_in_cxx20.verify.cpp

6 lines

codecvt_char32_t_char.depr_in_cxx20.verify.cpp

6 lines

numerics/

numbers/

illformed.verify.cpp

5 lines

rand/

rand.req/

rand.req.urng/

uniform_random_bit_generator.compile.pass.cpp

2 lines

re/

re.results/

re.results.size/

empty.verify.cpp

7 lines

strings/

basic.string/

string.capacity/

empty.verify.cpp

16 lines

reserve.deprecated_in_cxx20.verify.cpp

4 lines

string.view/

string.view.capacity/

empty.verify.cpp

7 lines

thread/

futures/

futures.async/

async.verify.cpp

10 lines

futures.promise/

copy_assign.verify.cpp

7 lines

copy_ctor.verify.cpp

7 lines

futures.unique_future/

copy_assign.verify.cpp

7 lines

copy_ctor.verify.cpp

7 lines

utilities/

allocator.adaptor/

allocator.adaptor.members/

allocate_size.verify.cpp

6 lines

allocate_size_hint.verify.cpp

6 lines

any/

any.nonmembers/

any.cast/

const_correctness.verify.cpp

5 lines

not_copy_constructible.verify.cpp

13 lines

format/

format.arguments/

format.args/

types.compile.pass.cpp

3 lines

format.formatter/

format.parse.ctx/

check_arg_id.verify.cpp

6 lines

next_arg_id.verify.cpp

6 lines

types.compile.pass.cpp

3 lines

function.objects/

func.bind_front/

bind_front.verify.cpp

7 lines

func.wrap/

func.wrap.func/

func.wrap.func.con/

alloc.verify.cpp

8 lines

alloc_F.verify.cpp

7 lines

alloc_function.verify.cpp

7 lines

alloc_nullptr.verify.cpp

8 lines

alloc_rfunction.verify.cpp

7 lines

deduct_F.verify.cpp

4 lines

negators/

binary_negate.depr_in_cxx17.verify.cpp

6 lines

not1.depr_in_cxx17.verify.cpp

6 lines

not2.depr_in_cxx17.verify.cpp

6 lines

unary_negate.depr_in_cxx17.verify.cpp

6 lines

memory/

allocator.traits/

allocator.traits.members/

allocate.verify.cpp

26 lines

default.allocator/

allocator.members/

allocate.constexpr.size.verify.cpp

5 lines

allocate.verify.cpp

8 lines

allocator_types.deprecated_in_cxx17.verify.cpp

3 lines

allocator_types.removed_in_cxx20.verify.cpp

5 lines

meta/

meta.trans/

meta.trans.other/

common_reference.compile.pass.cpp

2 lines

smartptr/

unique.ptr/

unique.ptr.class/

unique.ptr.observers/

dereference.verify.cpp

7 lines

op_arrow.verify.cpp

5 lines

utility/

utility.underlying/

to_underlying.verify.cpp

4 lines

support/

test.support/

test_macros_header.no_exceptions.verify.cpp

3 lines

test_macros_header.no_rtti.verify.cpp

3 lines

[libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp testsClosedPublicActions

Details

Diff Detail

Event Timeline

Large Diff

Revision ContentsChangeset List

Diff 506202

libcxx/test/libcxx/algorithms/alg.modifying.operations/alg.random.shuffle/random_shuffle.depr_in_cxx14.verify.cpp

libcxx/test/libcxx/atomics/bit-int.verify.cpp

libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp

libcxx/test/libcxx/containers/associative/non_const_comparator.incomplete.verify.cpp

libcxx/test/libcxx/containers/associative/non_const_comparator.verify.cpp

libcxx/test/libcxx/containers/unord/non_const_comparator.incomplete.verify.cpp

libcxx/test/libcxx/containers/unord/non_const_comparator.verify.cpp

libcxx/test/libcxx/depr/depr.auto.ptr/auto.ptr/auto_ptr.depr_in_cxx11.verify.cpp

libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/address.depr_in_cxx17.verify.cpp

libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.cxx2a.verify.cpp

libcxx/test/libcxx/depr/depr.default.allocator/allocator.members/allocate.depr_in_cxx17.verify.cpp

libcxx/test/libcxx/depr/depr.function.objects/adaptors.depr_in_cxx11.verify.cpp

libcxx/test/libcxx/diagnostics/nodiscard_aftercxx17.verify.cpp

libcxx/test/libcxx/diagnostics/nodiscard_extensions.compile.pass.cpp

libcxx/test/libcxx/diagnostics/nodiscard_extensions.verify.cpp

libcxx/test/libcxx/iterators/predef.iterators/__unconstrained_reverse_iterator/reverse.iter.cons/ctor.iter.explicit.verify.cpp

libcxx/test/libcxx/iterators/predef.iterators/reverse.iterators/bad_template_argument.verify.cpp

libcxx/test/libcxx/language.support/support.dynamic/aligned_alloc_availability.verify.cpp

libcxx/test/libcxx/numerics/rand/rand.device/has-no-random-device.verify.cpp

libcxx/test/libcxx/ranges/version.compile.pass.cpp

libcxx/test/libcxx/selftest/verify.cpp/no-werror.verify.cpp

libcxx/test/libcxx/thread/atomic.availability.verify.cpp

libcxx/test/libcxx/thread/barrier.availability.verify.cpp

libcxx/test/libcxx/thread/latch.availability.verify.cpp

libcxx/test/libcxx/thread/semaphore.availability.verify.cpp

libcxx/test/libcxx/thread/thread.barrier/version.compile.pass.cpp

libcxx/test/libcxx/thread/thread.latch/version.compile.pass.cpp

libcxx/test/libcxx/thread/thread.lock/thread.lock.guard/nodiscard.verify.cpp

libcxx/test/libcxx/thread/thread.semaphore/version.compile.pass.cpp

libcxx/test/libcxx/utilities/format/version.compile.pass.cpp

libcxx/test/std/atomics/atomics.types.generic/standard_layout.compile.pass.cpp

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/copy.assign.ptr.volatile.verify.cpp

libcxx/test/std/atomics/atomics.types.operations/atomics.types.operations.req/copy.assign.volatile.verify.cpp

libcxx/test/std/concepts/concepts.compare/concept.equalitycomparable/equality_comparable.compile.pass.cpp

libcxx/test/std/concepts/concepts.compare/concept.equalitycomparable/equality_comparable_with.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.common/common_with.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.commonref/common_reference.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.constructible/constructible_from.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.copyconstructible/copy_constructible.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.default.init/default_initializable.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.default.init/default_initializable.verify.cpp

libcxx/test/std/concepts/concepts.lang/concept.destructible/destructible.compile.pass.cpp

libcxx/test/std/concepts/concepts.lang/concept.moveconstructible/move_constructible.compile.pass.cpp

libcxx/test/std/concepts/concepts.object/copyable.compile.pass.cpp

libcxx/test/std/concepts/concepts.object/movable.compile.pass.cpp

libcxx/test/std/concepts/concepts.object/regular.compile.pass.cpp

libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp

libcxx/test/std/containers/associative/map/map.access/empty.verify.cpp

libcxx/test/std/containers/associative/multimap/empty.verify.cpp

libcxx/test/std/containers/associative/multiset/empty.verify.cpp

libcxx/test/std/containers/associative/set/empty.verify.cpp

libcxx/test/std/containers/container.adaptors/priority.queue/priqueue.members/empty.verify.cpp

libcxx/test/std/containers/container.adaptors/queue/queue.defn/empty.verify.cpp

libcxx/test/std/containers/container.adaptors/stack/stack.defn/empty.verify.cpp

libcxx/test/std/containers/sequences/array/empty.verify.cpp

libcxx/test/std/containers/sequences/deque/deque.capacity/empty.verify.cpp

libcxx/test/std/containers/sequences/forwardlist/empty.verify.cpp

libcxx/test/std/containers/sequences/list/list.capacity/empty.verify.cpp

libcxx/test/std/containers/sequences/vector.bool/empty.verify.cpp

libcxx/test/std/containers/sequences/vector/vector.capacity/empty.verify.cpp

libcxx/test/std/containers/sequences/vector/vector.cons/copy.move_only.verify.cpp

libcxx/test/std/containers/unord/unord.map/empty.verify.cpp

libcxx/test/std/containers/unord/unord.multimap/empty.verify.cpp

libcxx/test/std/containers/unord/unord.multiset/empty.verify.cpp

libcxx/test/std/containers/unord/unord.set/empty.verify.cpp

libcxx/test/std/containers/views/views.span/span.cons/iterator_len.verify.cpp

libcxx/test/std/containers/views/views.span/span.cons/iterator_sentinel.verify.cpp

libcxx/test/std/depr/depr.lib.binders/depr.lib.bind.1st/bind1st.depr_in_cxx11.verify.cpp

libcxx/test/std/depr/depr.lib.binders/depr.lib.bind.2nd/bind2nd.depr_in_cxx11.verify.cpp

libcxx/test/std/depr/depr.lib.binders/depr.lib.binder.1st/binder1st.depr_in_cxx11.verify.cpp

libcxx/test/std/depr/depr.lib.binders/depr.lib.binder.2nd/binder2nd.depr_in_cxx11.verify.cpp

libcxx/test/std/input.output/filesystems/class.path/path.member/path.decompose/empty.verify.cpp

libcxx/test/std/input.output/iostream.format/quoted.manip/quoted_char.verify.cpp

[libc++] Remove unnecessary main() function in .compile.pass.cpp and .verify.cpp tests
ClosedPublic
Actions

Revision Contents
Changeset List