This is an archive of the discontinued LLVM Phabricator instance.

Differential D145919

[libc++] Add missing include in exception_ptr.h
ClosedPublic

Authored by hans on Mar 13 2023, 3:46 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rGc341d5030503: [libc++] Add missing include in exception_ptr.h
Summary

Windows builds were failing due to missing include for std::addressof after D145095.

Diff Detail

Unit TestsFailed

TimeTest
4,220 mslibcxx CI FreeBSD 13 amd64 > llvm-libc++-shared-cfg-in.std/thread/thread_mutex/thread_lock/thread_lock_shared/thread_lock_shared_locking::lock.pass.cpp

Event Timeline

hans created this revision.Mar 13 2023, 3:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 13 2023, 3:46 AM
hans requested review of this revision.Mar 13 2023, 3:46 AM
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 13 2023, 3:46 AM
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Mar 13 2023, 5:30 AM
This revision is now accepted and ready to land.Mar 13 2023, 5:30 AM
Harbormaster completed remote builds in B218981: Diff 504579.Mar 13 2023, 5:44 AM
This revision was landed with ongoing or failed builds.Mar 13 2023, 7:22 AM
Closed by commit rGc341d5030503: [libc++] Add missing include in exception_ptr.h (authored by hans). · Explain Why
This revision was automatically updated to reflect the committed changes.
hans added a commit: rGc341d5030503: [libc++] Add missing include in exception_ptr.h.

Revision Contents

PathSize
libcxx/
include/
__exception/
1 line

Diff 504579

libcxx/include/__exception/exception_ptr.h

//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// //
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information. // See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
// //
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
#ifndef _LIBCPP___EXCEPTION_EXCEPTION_PTR_H #ifndef _LIBCPP___EXCEPTION_EXCEPTION_PTR_H
#define _LIBCPP___EXCEPTION_EXCEPTION_PTR_H #define _LIBCPP___EXCEPTION_EXCEPTION_PTR_H
#include <__config> #include <__config>
#include <__exception/operations.h> #include <__exception/operations.h>
#include <__memory/addressof.h>
#include <cstddef> #include <cstddef>
#include <cstdlib> #include <cstdlib>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
namespace std { // purposefully not using versioning namespace namespace std { // purposefully not using versioning namespace
▲ Show 20 Lines • Show All 87 Lines • Show Last 20 Lines