[flang] Check that a SELECT TYPE selector is not a procedure

[klausler]

Summary

A SELECT TYPE statement's selector must be a variable or expression,
not a procedure; specifically, a function with a polymorphic result
is unacceptable.

[clementval]

LGTM

flang/lib/Semantics/check-select-type.cpp

private:
   bool hasErrors_{false};
 };
 
 void SelectTypeChecker::Enter(const parser::SelectTypeConstruct &construct) {
   const auto &selectTypeStmt{
       std::get<parser::Statement<parser::SelectTypeStmt>>(construct.t)};
   const auto &selectType{selectTypeStmt.statement};
   const auto &unResolvedSel{std::get<parser::Selector>(selectType.t)};
-  const auto *selector{GetExprFromSelector(unResolvedSel)};
-
-  if (!selector) {
-    return; // expression semantics failed on Selector
-  }
-  if (auto exprType{selector->GetType()}) {
+  if (const auto *selector{GetExprFromSelector(unResolvedSel)}) {
+    if (IsProcedure(*selector)) {
+      context_.Say(
+          selectTypeStmt.source, "Selector may not be a procedure"_err_en_US);
+    } else if (auto exprType{selector->GetType()}) {
       const auto &typeCaseList{
           std::get<std::list<parser::SelectTypeConstruct::TypeCase>>(
               construct.t)};
       TypeCaseValues{context_, *exprType}.Check(typeCaseList);
     }
   }
+}
 
 const SomeExpr *SelectTypeChecker::GetExprFromSelector(
     const parser::Selector &selector) {
   return common::visit([](const auto &x) { return GetExpr(x); }, selector.u);
 }
 } // namespace Fortran::semantics

flang/test/Semantics/selecttype01.f90

select type (unlim_polymorphic)
     type is  (rectangle)
       print *, "hello rect"
     type is  (square)
       print *, "hello square"
     CLASS DEFAULT
       print *, "default"
   end select
 end
+
+subroutine CheckNotProcedure
+  use m1
+  !ERROR: Selector may not be a procedure
+  select type (x=>f)
+  end select
+ contains
+  function f() result(res)
+    class(shape), allocatable :: res
+  end
+end