This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Remove conditional usage of rvalue references in C++03
ClosedPublic

Authored by ldionne on Mar 9 2023, 9:30 AM.

Details

Summary

This one is easy -- Clang supports rvalue references in C++03 mode, so
we should be able to remove that conditional.

Diff Detail

Event Timeline

ldionne created this revision.Mar 9 2023, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 9:30 AM
ldionne requested review of this revision.Mar 9 2023, 9:30 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 9:30 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik accepted this revision.Mar 9 2023, 10:14 AM
philnik added a subscriber: philnik.
philnik added inline comments.
libcxx/include/exception
329

Maybe also std::forward instead of static_casting?

This revision is now accepted and ready to land.Mar 9 2023, 10:14 AM
ldionne updated this revision to Diff 504119.Mar 10 2023, 6:04 AM

Address comments and rebase (should fix CI).

Mordante accepted this revision.Mar 10 2023, 9:18 AM
Mordante added a subscriber: Mordante.

LGTM!

This revision was landed with ongoing or failed builds.Mar 10 2023, 11:44 AM
This revision was automatically updated to reflect the committed changes.