This is an archive of the discontinued LLVM Phabricator instance.

Differential D145648

[clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`
ClosedPublic

Authored by yaxunl on Mar 8 2023, 9:06 PM.

Details

Reviewers
tra
arsenm
Commits
rGe94c171ddb03: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`
Summary

-ffp-contract=fast-honor-pragmas is a valid option recognized
by clang -cc1 but it is missed by clang driver.

Diff Detail

Event Timeline

yaxunl created this revision.Mar 8 2023, 9:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2023, 9:06 PM
yaxunl requested review of this revision.Mar 8 2023, 9:06 PM
Herald added a subscriber: MaskRay. · View Herald TranscriptMar 8 2023, 9:06 PM
Harbormaster completed remote builds in B218284: Diff 503612.Mar 8 2023, 10:06 PM
arsenm accepted this revision.Aug 18 2023, 4:48 AM
arsenm added a subscriber: arsenm.

LGTM, not recognizing this in the driver is incomplete

This revision is now accepted and ready to land.Aug 18 2023, 4:48 AM
Herald added a subscriber: wdng. · View Herald TranscriptAug 18 2023, 4:48 AM
This revision was landed with ongoing or failed builds.Aug 24 2023, 4:51 PM
Closed by commit rGe94c171ddb03: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas` (authored by yaxunl). · Explain Why
This revision was automatically updated to reflect the committed changes.
yaxunl added a commit: rGe94c171ddb03: [clang][Driver] recognize `-ffp-contract=fast-honor-pragmas`.
Herald added a project: Restricted Project. · View Herald TranscriptAug 24 2023, 4:51 PM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
3 lines
test/
Driver/
4 lines

Diff 553306

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 2,949 Lines • ▼ Show 20 Lines for (const Arg *A : Args) {
// Validate and pass through -ffp-contract option. // Validate and pass through -ffp-contract option.
case options::OPT_ffp_contract: { case options::OPT_ffp_contract: {
StringRef Val = A->getValue(); StringRef Val = A->getValue();
if (PreciseFPModel) { if (PreciseFPModel) {
// -ffp-model=precise enables ffp-contract=on. // -ffp-model=precise enables ffp-contract=on.
// -ffp-model=precise sets PreciseFPModel to on and Val to // -ffp-model=precise sets PreciseFPModel to on and Val to
// "precise". FPContract is set. // "precise". FPContract is set.
; ;
} else if (Val.equals("fast") || Val.equals("on") || Val.equals("off")) { } else if (Val.equals("fast") || Val.equals("on") || Val.equals("off") ||
Val.equals("fast-honor-pragmas")) {
FPContract = Val; FPContract = Val;
LastSeenFfpContractOption = Val; LastSeenFfpContractOption = Val;
} else } else
D.Diag(diag::err_drv_unsupported_option_argument) D.Diag(diag::err_drv_unsupported_option_argument)
<< A->getSpelling() << Val; << A->getSpelling() << Val;
break; break;
} }
▲ Show 20 Lines • Show All 5,743 Lines • Show Last 20 Lines

clang/test/Driver/fp-contract.c

Show All 15 Lines
// RUN: %clang -### -ffast-math -ffp-contract=off -c %s 2>&1 \ // RUN: %clang -### -ffast-math -ffp-contract=off -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FPC-OFF %s // RUN: | FileCheck --check-prefix=CHECK-FPC-OFF %s
// CHECK-FPC-OFF: "-ffp-contract=off" // CHECK-FPC-OFF: "-ffp-contract=off"
// RUN: %clang -### -ffast-math -ffp-contract=fast -c %s 2>&1 \ // RUN: %clang -### -ffast-math -ffp-contract=fast -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s // RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s
// RUN: %clang -### -ffast-math -ffp-contract=fast-honor-pragmas -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FPC-FAST-HONOR %s
// CHECK-FPC-FAST-HONOR: "-ffp-contract=fast-honor-pragmas"
// RUN: %clang -### -ffp-contract=fast -ffast-math -c %s 2>&1 \ // RUN: %clang -### -ffp-contract=fast -ffast-math -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s // RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s
// RUN: %clang -### -ffp-contract=on -ffast-math -c %s 2>&1 \ // RUN: %clang -### -ffp-contract=on -ffast-math -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s // RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s
// RUN: %clang -### -ffp-contract=off -ffast-math -c %s 2>&1 \ // RUN: %clang -### -ffp-contract=off -ffast-math -c %s 2>&1 \
// RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s // RUN: | FileCheck --check-prefix=CHECK-FPC-FAST %s
// RUN: %clang -### -ffp-contract=fast -fno-fast-math -c %s 2>&1 \ // RUN: %clang -### -ffp-contract=fast -fno-fast-math -c %s 2>&1 \
▲ Show 20 Lines • Show All 205 Lines • Show Last 20 Lines