This is an archive of the discontinued LLVM Phabricator instance.

[SelectionDAG] Deprecate isNullValue and isAllOnesValue
ClosedPublic

Authored by kazu on Mar 5 2023, 11:55 PM.

Details

Summary

This patch deprecates them as there are no known uses of these
functions in the project.

Diff Detail

Event Timeline

kazu created this revision.Mar 5 2023, 11:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 11:55 PM
Herald added a subscriber: ecnelises. · View Herald Transcript
kazu requested review of this revision.Mar 5 2023, 11:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 11:55 PM
dblaikie accepted this revision.Mar 6 2023, 9:06 PM

Sure, sounds good. (maybe document the history of how we ended up with duplicate functionality/different names for the same thing? (I haven't checked the history - if you introduced the new names, maybe link to where they were introduced and/or summarize why they were introduced, etc))

This revision is now accepted and ready to land.Mar 6 2023, 9:06 PM
MaskRay accepted this revision.EditedMar 7 2023, 4:41 PM

I think you can just remove the methods. They seem pretty uncommon and downstream projects can simply migrate uses when integrating this patch.

The isAllOnesValue name may come from Constant.

This revision was landed with ongoing or failed builds.Mar 12 2023, 6:25 PM
This revision was automatically updated to reflect the committed changes.