Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D145355

[AggressiveInstCombine] Pre-Commit test for D144445 (NFC)
ClosedPublic
Actions

Authored by khei4 on Mar 5 2023, 11:03 PM.

Details

Reviewers
None
Commits
rGc7a3284de305: [AggressiveInstCombine] Pre-Commit test for D144445 (NFC)
Summary

precommit test for D144445

  • change planned to apply on InstSimplify to AggressiveInstCombine
  • residues of test changes moved to llvm/test/Transforms/InstSimplify/load.ll

Diff Detail

Event Timeline

khei4 created this revision.Mar 5 2023, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 11:03 PM
khei4 requested review of this revision.Mar 5 2023, 11:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 5 2023, 11:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B217499: Diff 502526.Mar 5 2023, 11:03 PM
khei4 mentioned this in D144445: [AggressiveInstCombine] folding load for constant global patterened arrays and structs by alignment.Mar 5 2023, 11:14 PM
khei4 updated this revision to Diff 502530.Mar 5 2023, 11:23 PM

revert fixed tests

Harbormaster completed remote builds in B217504: Diff 502530.Mar 5 2023, 11:24 PM
khei4 updated this revision to Diff 502531.Mar 5 2023, 11:24 PM
khei4 added a child revision: D144445: [AggressiveInstCombine] folding load for constant global patterened arrays and structs by alignment.

fix wrong diff

khei4 edited the summary of this revision. (Show Details)Mar 5 2023, 11:28 PM
Harbormaster completed remote builds in B217505: Diff 502531.Mar 6 2023, 1:27 AM
khei4 retitled this revision from [AggressiveInstCombine] Pre-Commit test for D144445 to [AggressiveInstCombine] Pre-Commit test for D144445 (NFC).Mar 8 2023, 10:22 PM
khei4 updated this revision to Diff 503629.Mar 8 2023, 10:33 PM
This comment was removed by khei4.
khei4 updated this revision to Diff 503631.Mar 8 2023, 10:34 PM

add ptr array tests, const offset tests

Harbormaster completed remote builds in B218300: Diff 503631.Mar 8 2023, 11:47 PM
khei4 updated this revision to Diff 503697.Mar 9 2023, 1:43 AM

tweak

Harbormaster completed remote builds in B218341: Diff 503697.Mar 9 2023, 3:03 AM
khei4 updated this revision to Diff 505365.Mar 14 2023, 10:26 PM

fix wrong load for pointer array

Harbormaster completed remote builds in B219547: Diff 505365.Mar 14 2023, 11:52 PM
khei4 updated this revision to Diff 506514.Mar 20 2023, 3:00 AM

add test cases

  • volatile load
  • ptrmasked pointer load
  • not inbounds load
Harbormaster completed remote builds in B220390: Diff 506514.Mar 20 2023, 3:53 AM
khei4 updated this revision to Diff 507299.Mar 22 2023, 3:27 AM

add

  • TODO comments with expected results
  • (un)successful non-inbounds cases
khei4 mentioned this in D146622: [AggressiveInstCombine] folding load for constant global patterened arrays and structs by GEP indices.Mar 22 2023, 3:56 AM
khei4 added a child revision: D146622: [AggressiveInstCombine] folding load for constant global patterened arrays and structs by GEP indices.Mar 22 2023, 3:59 AM
Harbormaster completed remote builds in B220974: Diff 507299.Mar 22 2023, 5:21 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 23 2023, 7:31 AM
This revision was landed with ongoing or failed builds.
Closed by commit rGc7a3284de305: [AggressiveInstCombine] Pre-Commit test for D144445 (NFC) (authored by khei4). · Explain Why
This revision was automatically updated to reflect the committed changes.
khei4 added a commit: rGc7a3284de305: [AggressiveInstCombine] Pre-Commit test for D144445 (NFC).

Revision Contents
Changeset List

PathSize
llvm/
test/
Transforms/
AggressiveInstCombine/
InstSimplify/
patterned-load.ll
load-patterned-aggregates.ll
75 lines
InstSimplify/
20 lines

Diff 502531

View Options

llvm/test/Transforms/AggressiveInstCombine/patterned-load.ll

Loading...
View Options

llvm/test/Transforms/InstSimplify/load-patterned-aggregates.ll

Loading...
View Options

llvm/test/Transforms/InstSimplify/load.ll

Loading...