This is an archive of the discontinued LLVM Phabricator instance.

[libc][NFC] Switch use of errno in src/time and test/src/time to libc_errno.
ClosedPublic

Authored by rtenneti on Mar 2 2023, 2:26 PM.

Details

Summary

Switch use of errno in src/time and test/src/time to libc_errno.

Diff Detail

Event Timeline

rtenneti created this revision.Mar 2 2023, 2:26 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 2 2023, 2:26 PM
rtenneti requested review of this revision.Mar 2 2023, 2:26 PM
rtenneti added a reviewer: jeffbailey.
sivachandra accepted this revision.Mar 2 2023, 2:32 PM
This revision is now accepted and ready to land.Mar 2 2023, 2:32 PM

While this patch is a step in the right direction, I think we also need to remove setting of errno from helper functions. See this RFC for the justification: https://discourse.llvm.org/t/rfc-improving-the-hermeticity-of-tests-with-respect-to-errno/68684