Page MenuHomePhabricator

rtenneti (Raman Tenneti)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 15 2020, 6:38 PM (31 w, 4 d)

Recent Activity

May 3 2021

rtenneti committed rGa72499e47537: [libc] Introduce asctime, asctime_r to LLVM libc (authored by rtenneti).
[libc] Introduce asctime, asctime_r to LLVM libc
May 3 2021, 5:15 PM
rtenneti closed D99686: [libc] Introduce asctime, asctime_r to LLVM libc.
May 3 2021, 5:15 PM · Restricted Project
rtenneti added a comment to D99686: [libc] Introduce asctime, asctime_r to LLVM libc.

Thanks for comments Siva. Made all the changes you have suggested.

May 3 2021, 5:12 PM · Restricted Project
rtenneti retitled D99686: [libc] Introduce asctime, asctime_r to LLVM libc from [libc] Introduces asctime, asctime_r to LLVM libc, based on C99/C2X/Single Unix Sp. to [libc] Introduce asctime, asctime_r to LLVM libc.
May 3 2021, 5:07 PM · Restricted Project
rtenneti updated the diff for D99686: [libc] Introduce asctime, asctime_r to LLVM libc.

Changed the internal asctime_internal to asctime.

May 3 2021, 5:05 PM · Restricted Project

Apr 19 2021

rtenneti updated the diff for D99686: [libc] Introduce asctime, asctime_r to LLVM libc.

Used __builtin_snprintf. Thanks Siva for the idea.

Apr 19 2021, 2:13 PM · Restricted Project

Apr 5 2021

rtenneti added a reviewer for D99686: [libc] Introduce asctime, asctime_r to LLVM libc: stanshebs.
Apr 5 2021, 3:25 PM · Restricted Project

Mar 31 2021

rtenneti requested review of D99686: [libc] Introduce asctime, asctime_r to LLVM libc.
Mar 31 2021, 2:07 PM · Restricted Project

Mar 22 2021

rtenneti committed rG8b35159ac720: [libc] Introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp. (authored by rtenneti).
[libc] Introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp.
Mar 22 2021, 2:04 PM
rtenneti closed D99046: [libc] Introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp..
Mar 22 2021, 2:04 PM · Restricted Project
rtenneti retitled D99046: [libc] Introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp. from This introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp. to [libc] Introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp..
Mar 22 2021, 2:01 PM · Restricted Project

Mar 21 2021

rtenneti requested review of D99046: [libc] Introduces gmtime_r to LLVM libc, based on C99/C2X/Single Unix Sp..
Mar 21 2021, 5:45 PM · Restricted Project

Mar 16 2021

rtenneti committed rGeaae52c1fd45: This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec. (authored by rtenneti).
This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec.
Mar 16 2021, 4:45 PM
rtenneti closed D98467: This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec..
Mar 16 2021, 4:45 PM · Restricted Project
rtenneti added a comment to D98467: This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec..

Thanks Siva for the comments. PTAL.

Mar 16 2021, 4:30 PM · Restricted Project
rtenneti updated the diff for D98467: This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec..

Fixed Siva's code review comments.

Mar 16 2021, 4:28 PM · Restricted Project

Mar 15 2021

rtenneti updated the diff for D98467: This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec..

Added missing OutOfRange test. Fixed few nits while reviewing.

Mar 15 2021, 10:50 AM · Restricted Project

Mar 11 2021

rtenneti requested review of D98467: This introduces gmtime to LLVM libc, based on C99/C2X/Single Unix Spec..
Mar 11 2021, 4:18 PM · Restricted Project

Feb 22 2021

rtenneti committed rG80bea4a0d581: [libc] [Obvious] Fix. (authored by rtenneti).
[libc] [Obvious] Fix.
Feb 22 2021, 7:16 PM
rtenneti committed rG034f5629256c: Changes to mktime to handle invalid dates, overflow and underflow… (authored by rtenneti).
Changes to mktime to handle invalid dates, overflow and underflow…
Feb 22 2021, 6:38 PM
rtenneti closed D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..
Feb 22 2021, 6:38 PM · Restricted Project

Feb 20 2021

rtenneti accepted D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..

arc diff command ran Lint and clang-format and fixed the formatting.

Lint for libc/test/src/time/mktime_test.cpp:

Feb 20 2021, 7:26 PM · Restricted Project
rtenneti updated the diff for D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..

Fixed comments - Deleted check_mktime function and replaced it
with initializing tm struct and EXPECT_TM_EQ macro.

Feb 20 2021, 7:24 PM · Restricted Project

Feb 18 2021

rtenneti updated the diff for D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..

Updated the comments for the years computation algorithm.

Feb 18 2021, 9:07 AM · Restricted Project

Feb 17 2021

rtenneti updated the diff for D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..

Made OutOfRange a static inline.

Feb 17 2021, 11:50 PM · Restricted Project
rtenneti updated the diff for D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..

Made all the changes Siva suggested.

Feb 17 2021, 11:35 PM · Restricted Project

Feb 16 2021

rtenneti retitled D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments. from Changes to mktime to handle invalid dates, overflow and underflow and calculating the correct date and thenumber of seconds even if invalid dates are passed as arguments. to Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..
Feb 16 2021, 10:15 AM · Restricted Project

Feb 14 2021

rtenneti requested review of D96684: Changes to mktime to handle invalid dates, overflow and underflow andcalculating the correct date and thenumber of seconds even if invalid datesare passed as arguments..
Feb 14 2021, 8:57 PM · Restricted Project

Nov 30 2020

rtenneti committed rG6f0f844e9af9: Initial commit of mktime. (authored by rtenneti).
Initial commit of mktime.
Nov 30 2020, 9:12 PM
rtenneti closed D91551: Initial commit of mktime..
Nov 30 2020, 9:12 PM · Restricted Project
rtenneti updated the summary of D91551: Initial commit of mktime..
Nov 30 2020, 5:15 PM · Restricted Project
rtenneti updated the summary of D91551: Initial commit of mktime..
Nov 30 2020, 5:14 PM · Restricted Project
rtenneti updated the summary of D91551: Initial commit of mktime..
Nov 30 2020, 5:14 PM · Restricted Project
rtenneti updated the summary of D91551: Initial commit of mktime..
Nov 30 2020, 5:13 PM · Restricted Project
rtenneti added inline comments to D91551: Initial commit of mktime..
Nov 30 2020, 5:08 PM · Restricted Project
rtenneti updated the diff for D91551: Initial commit of mktime..

Added "not" to the comment.

Nov 30 2020, 10:30 AM · Restricted Project
rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed Siva's comments and added a TODO.

Nov 30 2020, 10:13 AM · Restricted Project

Nov 22 2020

rtenneti added a comment to D91551: Initial commit of mktime..

Removed the TODO. Thanks Jeff.

Nov 22 2020, 6:42 PM · Restricted Project
rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed the todo.

Nov 22 2020, 6:41 PM · Restricted Project
rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed Jeff's comments.

Nov 22 2020, 6:35 PM · Restricted Project
rtenneti added a comment to D91551: Initial commit of mktime..

Jeff and I have made the changes. Please take another look. Thanks.

Nov 22 2020, 10:47 AM · Restricted Project
rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed code review comments.

Nov 22 2020, 10:37 AM · Restricted Project

Nov 21 2020

rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed comments.

Nov 21 2020, 6:54 PM · Restricted Project

Nov 17 2020

rtenneti updated the diff for D91551: Initial commit of mktime..

Fixed the comments from Fangrui.

Nov 17 2020, 9:08 AM · Restricted Project

Nov 16 2020

rtenneti updated the diff for D91551: Initial commit of mktime..

Remove anonymous namespace, fix typos in ILP64 msg.
Removed duplicate arrays for days calculation.

Nov 16 2020, 4:39 PM · Restricted Project
rtenneti updated the summary of D91551: Initial commit of mktime..
Nov 16 2020, 10:26 AM · Restricted Project
rtenneti updated the summary of D91551: Initial commit of mktime..
Nov 16 2020, 10:17 AM · Restricted Project
rtenneti added a reviewer for D91551: Initial commit of mktime.: sivachandra.
Nov 16 2020, 10:07 AM · Restricted Project
rtenneti requested review of D91551: Initial commit of mktime..
Nov 16 2020, 10:03 AM · Restricted Project