Page MenuHomePhabricator

[libc++][spaceship] Implement `operator<=>` for `forward_list`
ClosedPublic

Authored by H-G-Hristov on Mar 2 2023, 10:47 AM.

Details

Summary

Implemented operator<=> for forward_list

Diff Detail

Unit TestsFailed

TimeTest
6,610 mslibcxx CI C++2b > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/5008b8b2ed52-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=/home/libcxx-builder/.buildkite-agent/builds/5008b8b2ed52-1/llvm-project/libcxx-ci/build/generic-cxx2b/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/5008b8b2ed52-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/5008b8b2ed52-1/llvm-project/libcxx-ci/build/generic-cxx2b/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/5008b8b2ed52-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules
3,840 mslibcxx CI Modular build > llvm-libc++-shared-cfg-in.libcxx::clang_tidy.sh.cpp
Script: -- : 'RUN: at line 15'; clang-tidy-16 /home/libcxx-builder/.buildkite-agent/builds/3c466550604e-1/llvm-project/libcxx-ci/libcxx/test/libcxx/clang_tidy.sh.cpp --warnings-as-errors=* -header-filter=.* --checks='-*,libcpp-*' --load=/home/libcxx-builder/.buildkite-agent/builds/3c466550604e-1/llvm-project/libcxx-ci/build/generic-modules/libcxx/test/tools/clang_tidy_checks/libcxx-tidy.plugin -- -nostdinc++ -I /home/libcxx-builder/.buildkite-agent/builds/3c466550604e-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3c466550604e-1/llvm-project/libcxx-ci/build/generic-modules/include/c++/v1 -I /home/libcxx-builder/.buildkite-agent/builds/3c466550604e-1/llvm-project/libcxx-ci/libcxx/test/support -std=c++2b -fmodules -fcxx-modules -Werror -Wall -Wctad-maybe-unsupported -Wextra -Wshadow -Wundef -Wno-unused-command-line-argument -Wno-attributes -Wno-pessimizing-move -Wno-c++11-extensions -Wno-noexcept-type -Wno-atomic-alignment -Wno-user-defined-literals -Wno-tautological-compare -Wsign-compare -Wunused-variable -Wunused-parameter -Wunreachable-code -Wno-unused-local-typedef -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_ENABLE_EXPERIMENTAL -D_LIBCPP_DISABLE_AVAILABILITY -Werror=thread-safety -Wuser-defined-warnings -fno-modules

Event Timeline

H-G-Hristov created this revision.Mar 2 2023, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 10:47 AM
Herald added a subscriber: yaxunl. · View Herald Transcript
H-G-Hristov requested review of this revision.Mar 2 2023, 10:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 10:47 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
  • Updated paper
  • Updated paper
  • Added missing _LIBCPP_HIDE_FROM_ABI
philnik accepted this revision.Mar 3 2023, 4:33 AM
philnik added a subscriber: philnik.

LGTM!

This revision is now accepted and ready to land.Mar 3 2023, 4:33 AM
This revision was automatically updated to reflect the committed changes.

@philnik Thank you for commiting!