This is an archive of the discontinued LLVM Phabricator instance.

Differential D145128

[libc] disable integration tests when using gcc
ClosedPublic

Authored by michaelrj on Mar 1 2023, 4:30 PM.

Details

Reviewers
sivachandra
lntue
Commits
rG8350494a612b: [libc] disable integration tests when using gcc
Summary

The integration tests were failing to build under GCC due to missing
compile options for using LLVM's libc++ and compiler-rt.

This should unblock https://github.com/llvm/llvm-project/issues/60467

Diff Detail

Event Timeline

michaelrj created this revision.Mar 1 2023, 4:30 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMar 1 2023, 4:30 PM
Herald added subscribers: libc-commits, ecnelises, tschuett. · View Herald Transcript
michaelrj requested review of this revision.Mar 1 2023, 4:30 PM
Harbormaster completed remote builds in B216858: Diff 501695.Mar 1 2023, 4:39 PM
sivachandra accepted this revision.Mar 1 2023, 4:49 PM
This revision is now accepted and ready to land.Mar 1 2023, 4:49 PM
lntue accepted this revision.Mar 1 2023, 7:05 PM
Closed by commit rG8350494a612b: [libc] disable integration tests when using gcc (authored by michaelrj). · Explain WhyMar 2 2023, 1:39 PM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG8350494a612b: [libc] disable integration tests when using gcc.

Revision Contents

PathSize
libc/
test/
4 lines
src/
4 lines

Diff 501964

libc/test/CMakeLists.txt

Show All 19 Lines
add_subdirectory(src) add_subdirectory(src)
add_subdirectory(utils) add_subdirectory(utils)
if(NOT LLVM_LIBC_FULL_BUILD) if(NOT LLVM_LIBC_FULL_BUILD)
return() return()
endif() endif()
if(NOT (${LIBC_TARGET_OS} STREQUAL "linux")) if(NOT (${LIBC_TARGET_OS} STREQUAL "linux") OR CMAKE_COMPILER_IS_GNUCXX)
# Integration tests are currently only available for linux. # Integration tests are currently only available for clang on linux.
return() return()
endif() endif()
add_subdirectory(integration) add_subdirectory(integration)

libc/test/src/CMakeLists.txt

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines
add_subdirectory(signal) add_subdirectory(signal)
add_subdirectory(spawn) add_subdirectory(spawn)
add_subdirectory(time) add_subdirectory(time)
if(${LIBC_TARGET_OS} STREQUAL "linux") if(${LIBC_TARGET_OS} STREQUAL "linux")
add_subdirectory(pthread) add_subdirectory(pthread)
endif() endif()
if(LLVM_RUNTIMES_BUILD OR LIBC_HDRGEN_EXE) if(LLVM_RUNTIMES_BUILD OR LIBC_HDRGEN_EXE OR CMAKE_COMPILER_IS_GNUCXX)
# The public API test below uses tablegen to generate the test # The public API test below uses tablegen to generate the test
# source file. Since tablegen is not available during a runtimes # source file. Since tablegen is not available during a runtimes
# build, we will skip the test. # build, we will skip the test.
# If a different libc-hdrgen binary is being used, then also we # If a different libc-hdrgen binary is being used, then also we
# skip the api-test as we cannot generate the test source file. # skip the api-test as we cannot generate the test source file.
# Additionally, this is an integration test and those only work with clang
# for the moment.
return() return()
endif() endif()
set(public_test ${CMAKE_CURRENT_BINARY_DIR}/public_api_test.cpp) set(public_test ${CMAKE_CURRENT_BINARY_DIR}/public_api_test.cpp)
set(entrypoints_name_list "") set(entrypoints_name_list "")
foreach(entry IN LISTS TARGET_LLVMLIBC_ENTRYPOINTS) foreach(entry IN LISTS TARGET_LLVMLIBC_ENTRYPOINTS)
get_target_property(entry_name ${entry} "ENTRYPOINT_NAME") get_target_property(entry_name ${entry} "ENTRYPOINT_NAME")
▲ Show 20 Lines • Show All 65 Lines • Show Last 20 Lines