This is an archive of the discontinued LLVM Phabricator instance.

Add test for Flags.data_flow_trace
ClosedPublic

Authored by yingcong-wu on Mar 1 2023, 12:18 AM.

Details

Summary

CollectDataFlow() uses Flags.collect_data_flow and
Flags.data_flow_trace at the same time. But in the null check before
the invocation, only Flags.collect_data_flow is checked, and there is
no other method to make sure Flags.data_flow_trace is not null, so
adding a null check for Flags.data_flow_trace.

Diff Detail

Event Timeline

yingcong-wu created this revision.Mar 1 2023, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 12:18 AM
Herald added a subscriber: Enna1. · View Herald Transcript
yingcong-wu requested review of this revision.Mar 1 2023, 12:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 1 2023, 12:18 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
karapsinie updated this revision to Diff 501432.Mar 1 2023, 2:13 AM
karapsinie added a subscriber: karapsinie.

arc diff git merge-base HEAD origin --update D145040

Herald added a project: Restricted Project. · View Herald Transcript
Herald added a subscriber: cfe-commits. · View Herald Transcript
karapsinie updated this revision to Diff 501449.EditedMar 1 2023, 3:19 AM

Attempt to restore.
Sorry for the breakdown. Please tell me how to fix what was done?

vitalybuka accepted this revision.Mar 7 2023, 10:04 PM
This revision is now accepted and ready to land.Mar 7 2023, 10:04 PM
vitalybuka edited the summary of this revision. (Show Details)Mar 7 2023, 10:14 PM
This revision was landed with ongoing or failed builds.Mar 7 2023, 10:18 PM
This revision was automatically updated to reflect the committed changes.