This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers] Disable armv7* sanitizers slice for ios
ClosedPublic

Authored by usama54321 on Feb 28 2023, 1:16 PM.

Details

Summary

Disable arvm7* sanitizer slice for ios as part of an effort to reduce toolchain size

rdar://104059106

Diff Detail

Event Timeline

usama54321 created this revision.Feb 28 2023, 1:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 1:16 PM
usama54321 requested review of this revision.Feb 28 2023, 1:16 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 28 2023, 1:16 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
usama54321 edited the summary of this revision. (Show Details)
rsundahl accepted this revision.Feb 28 2023, 1:26 PM

LGTM (see note)

compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
155

This looks good to me provided you are intentionally very narrowly targeting ios only.

This revision is now accepted and ready to land.Feb 28 2023, 1:26 PM
usama54321 added inline comments.Feb 28 2023, 1:42 PM
compiler-rt/cmake/Modules/CompilerRTDarwinUtils.cmake
155

Yes that is intended

thetruestblue accepted this revision.EditedFeb 28 2023, 3:07 PM

You could probably use FILTER to remove all arm7* variants in one command, but there's no real need to do that.

LGTM

usama54321 updated this revision to Diff 501876.Mar 2 2023, 8:06 AM

use filter instead of remove

This revision was landed with ongoing or failed builds.Mar 2 2023, 8:09 AM
This revision was automatically updated to reflect the committed changes.