This is an archive of the discontinued LLVM Phabricator instance.

[libc] Fix mismatch in exception decl
ClosedPublic

Authored by jeffbailey on Feb 25 2023, 6:05 PM.

Details

Summary

When running the libc tests under vscode, I got an error about a
mismatches exception declaration for strerror. Since string.h
seems to be getting included transitively anyway, just include
it and rely on its definition.

Diff Detail

Event Timeline

jeffbailey created this revision.Feb 25 2023, 6:05 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 25 2023, 6:05 PM
jeffbailey requested review of this revision.Feb 25 2023, 6:05 PM
michaelrj accepted this revision.Feb 27 2023, 11:48 AM

LGTM. If I remember correctly, that extern declaration is a leftover from before we had a version of strerror. Make sure to test both in fullbuild and overlay modes before landing.

This revision is now accepted and ready to land.Feb 27 2023, 11:48 AM
This revision was automatically updated to reflect the committed changes.