This is an archive of the discontinued LLVM Phabricator instance.

Differential D144757

Allow building with CMAKE_SYSTEM_NAME=Generic
ClosedPublic

Authored by michaelplatings on Feb 24 2023, 1:13 PM.

Details

Reviewers
stuij
Commits
rG1422f1bf2b14: Allow building with CMAKE_SYSTEM_NAME=Generic
Summary

This is important for building runtimes for bare metal targets.

Diff Detail

Unit TestsFailed

TimeTest
60,040 msx64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp
60,110 msx64 debian > libFuzzer.libFuzzer::fuzzer-leak.test
60,040 msx64 debian > libFuzzer.libFuzzer::minimize_crash.test

Event Timeline

michaelplatings created this revision.Feb 24 2023, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 1:13 PM
michaelplatings requested review of this revision.Feb 24 2023, 1:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2023, 1:13 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
michaelplatings added a reviewer: stuij.Feb 24 2023, 1:19 PM
Harbormaster completed remote builds in B215822: Diff 500281.Feb 24 2023, 11:16 PM
stuij accepted this revision.Feb 27 2023, 1:34 AM

LGTM

This revision is now accepted and ready to land.Feb 27 2023, 1:34 AM
This revision was landed with ongoing or failed builds.Feb 27 2023, 2:24 AM
Closed by commit rG1422f1bf2b14: Allow building with CMAKE_SYSTEM_NAME=Generic (authored by michaelplatings). · Explain Why
This revision was automatically updated to reflect the committed changes.
michaelplatings added a commit: rG1422f1bf2b14: Allow building with CMAKE_SYSTEM_NAME=Generic.

Revision Contents

PathSize
llvm/
cmake/
modules/
28 lines

Diff 500281

llvm/cmake/modules/HandleLLVMOptions.cmake

Show First 20 Lines • Show All 135 Lines • ▼ Show 20 Linesif(WIN32)
set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
if(CYGWIN) if(CYGWIN)
set(LLVM_ON_WIN32 0) set(LLVM_ON_WIN32 0)
set(LLVM_ON_UNIX 1) set(LLVM_ON_UNIX 1)
else(CYGWIN) else(CYGWIN)
set(LLVM_ON_WIN32 1) set(LLVM_ON_WIN32 1)
set(LLVM_ON_UNIX 0) set(LLVM_ON_UNIX 0)
endif(CYGWIN) endif(CYGWIN)
else(WIN32) elseif(FUCHSIA OR UNIX)
if(FUCHSIA OR UNIX)
set(LLVM_ON_WIN32 0) set(LLVM_ON_WIN32 0)
set(LLVM_ON_UNIX 1) set(LLVM_ON_UNIX 1)
if(APPLE OR ${CMAKE_SYSTEM_NAME} MATCHES "AIX") if(APPLE OR ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
else() else()
set(LLVM_HAVE_LINK_VERSION_SCRIPT 1) set(LLVM_HAVE_LINK_VERSION_SCRIPT 1)
endif() endif()
else(FUCHSIA OR UNIX) elseif(CMAKE_SYSTEM_NAME STREQUAL "Generic")
set(LLVM_ON_WIN32 0)
set(LLVM_ON_UNIX 0)
set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
else()
MESSAGE(SEND_ERROR "Unable to determine platform") MESSAGE(SEND_ERROR "Unable to determine platform")
endif(FUCHSIA OR UNIX) endif()
endif(WIN32)
if (CMAKE_SYSTEM_NAME MATCHES "OS390") if (CMAKE_SYSTEM_NAME MATCHES "OS390")
set(LLVM_HAVE_LINK_VERSION_SCRIPT 0) set(LLVM_HAVE_LINK_VERSION_SCRIPT 0)
endif() endif()
set(EXEEXT ${CMAKE_EXECUTABLE_SUFFIX}) set(EXEEXT ${CMAKE_EXECUTABLE_SUFFIX})
set(LTDL_SHLIB_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX}) set(LTDL_SHLIB_EXT ${CMAKE_SHARED_LIBRARY_SUFFIX})
▲ Show 20 Lines • Show All 1,126 Lines • Show Last 20 Lines