This is an archive of the discontinued LLVM Phabricator instance.

Differential D144630

[Flang][Driver] NFC: Fix plugin test to work on Mac
ClosedPublic

Authored by kiranchandramohan on Feb 23 2023, 2:58 AM.

Details

Reviewers
awarzynski
DavidTruby
Commits
rG94bf67c5c63d: [Flang][Driver] NFC: Fix plugin test to work on Mac
Summary

Minor modifications to Diagnostic expectation to match the error generated in Mac.
Tested on M1 Mac.

Diff Detail

Event Timeline

kiranchandramohan created this revision.Feb 23 2023, 2:58 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 23 2023, 2:58 AM
kiranchandramohan requested review of this revision.Feb 23 2023, 2:58 AM
Herald added a subscriber: jdoerfert. · View Herald TranscriptFeb 23 2023, 2:58 AM
Harbormaster completed remote builds in B215466: Diff 499785.Feb 23 2023, 3:17 AM
awarzynski accepted this revision.Feb 23 2023, 8:01 AM

Thanks Kiran!

This revision is now accepted and ready to land.Feb 23 2023, 8:01 AM
Closed by commit rG94bf67c5c63d: [Flang][Driver] NFC: Fix plugin test to work on Mac (authored by kiranchandramohan). · Explain WhyFeb 23 2023, 10:13 AM
This revision was automatically updated to reflect the committed changes.
kiranchandramohan added a commit: rG94bf67c5c63d: [Flang][Driver] NFC: Fix plugin test to work on Mac.

Revision Contents

PathSize
flang/
test/
Driver/
2 lines

Diff 499908

flang/test/Driver/pass-plugin-not-found.f90

! Check the correct error diagnostic is reported when a pass plugin shared object isn't found ! Check the correct error diagnostic is reported when a pass plugin shared object isn't found
! REQUIRES: plugins, shell ! REQUIRES: plugins, shell
! RUN: not %flang -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR ! RUN: not %flang -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR
! RUN: not %flang_fc1 -emit-llvm -o /dev/null -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR ! RUN: not %flang_fc1 -emit-llvm -o /dev/null -fpass-plugin=X.Y %s 2>&1 | FileCheck %s --check-prefix=ERROR
! The exact wording of the error message depends on the system dlerror. ! The exact wording of the error message depends on the system dlerror.
! ERROR: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': {{.*}}: No such file or directory' ! ERROR: error: unable to load plugin 'X.Y': 'Could not load library 'X.Y': {{.*}}: {{.*}}{{[Nn]}}o such file{{.*}}'