This is an archive of the discontinued LLVM Phabricator instance.

Differential D144498

[libc++][format] Removes transitive type_traits.
ClosedPublic

Authored by Mordante on Feb 21 2023, 8:32 AM.

Details

Reviewers
philnik
Group Reviewers
Restricted Project
Commits
rG306b24c0bdfb: [libc++][format] Removes transitive type_traits.

Diff Detail

Event Timeline

Mordante created this revision.Feb 21 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 8:32 AM
Mordante requested review of this revision.Feb 21 2023, 8:32 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 8:32 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik accepted this revision.Feb 21 2023, 8:33 AM
philnik added a subscriber: philnik.

LGTM assuming the CI is happy.

This revision is now accepted and ready to land.Feb 21 2023, 8:33 AM
Harbormaster completed remote builds in B215037: Diff 499192.Feb 21 2023, 3:40 PM
Closed by commit rG306b24c0bdfb: [libc++][format] Removes transitive type_traits. (authored by Mordante). · Explain WhyFeb 22 2023, 8:18 AM
This revision was automatically updated to reflect the committed changes.
Mordante added a commit: rG306b24c0bdfb: [libc++][format] Removes transitive type_traits..

Revision Contents

PathSize
libcxx/
include/
__format/
1 line
1 line
1 line
2 lines
1 line
test/
libcxx/
transitive_includes/
1 line
1 line
1 line
1 line
1 line
1 line

Diff 499519

libcxx/include/__format/buffer.h

Show All 24 Lines
#include <__iterator/back_insert_iterator.h> #include <__iterator/back_insert_iterator.h>
#include <__iterator/concepts.h> #include <__iterator/concepts.h>
#include <__iterator/incrementable_traits.h> #include <__iterator/incrementable_traits.h>
#include <__iterator/iterator_traits.h> #include <__iterator/iterator_traits.h>
#include <__iterator/wrap_iter.h> #include <__iterator/wrap_iter.h>
#include <__utility/move.h> #include <__utility/move.h>
#include <cstddef> #include <cstddef>
#include <string_view> #include <string_view>
#include <type_traits>
#include <vector> #include <vector>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 532 Lines • Show Last 20 Lines

libcxx/include/__format/concepts.h

Show All 12 Lines
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__concepts/semiregular.h> #include <__concepts/semiregular.h>
#include <__config> #include <__config>
#include <__format/format_fwd.h> #include <__format/format_fwd.h>
#include <__format/format_parse_context.h> #include <__format/format_parse_context.h>
#include <__type_traits/is_specialization.h> #include <__type_traits/is_specialization.h>
#include <__utility/pair.h> #include <__utility/pair.h>
#include <tuple> #include <tuple>
#include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#if _LIBCPP_STD_VER >= 20 #if _LIBCPP_STD_VER >= 20
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines

libcxx/include/__format/format_arg_store.h

Show All 16 Lines
#include <__concepts/arithmetic.h> #include <__concepts/arithmetic.h>
#include <__concepts/same_as.h> #include <__concepts/same_as.h>
#include <__config> #include <__config>
#include <__format/concepts.h> #include <__format/concepts.h>
#include <__format/format_arg.h> #include <__format/format_arg.h>
#include <__utility/forward.h> #include <__utility/forward.h>
#include <string> #include <string>
#include <string_view> #include <string_view>
#include <type_traits>
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#if _LIBCPP_STD_VER >= 20 #if _LIBCPP_STD_VER >= 20
namespace __format { namespace __format {
/// \returns The @c __arg_t based on the type of the formatting argument. /// \returns The @c __arg_t based on the type of the formatting argument.
▲ Show 20 Lines • Show All 220 Lines • Show Last 20 Lines

libcxx/include/__format/formatter_integer.h

Show All 13 Lines
#include <__concepts/arithmetic.h> #include <__concepts/arithmetic.h>
#include <__config> #include <__config>
#include <__format/concepts.h> #include <__format/concepts.h>
#include <__format/format_parse_context.h> #include <__format/format_parse_context.h>
#include <__format/formatter.h> #include <__format/formatter.h>
#include <__format/formatter_integral.h> #include <__format/formatter_integral.h>
#include <__format/formatter_output.h> #include <__format/formatter_output.h>
#include <__format/parser_std_format_spec.h> #include <__format/parser_std_format_spec.h>
#include <__type_traits/is_same.h>
#include <__type_traits/make_32_64_or_128_bit.h> #include <__type_traits/make_32_64_or_128_bit.h>
#include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_BEGIN_NAMESPACE_STD
#if _LIBCPP_STD_VER >= 20 #if _LIBCPP_STD_VER >= 20
▲ Show 20 Lines • Show All 76 Lines • Show Last 20 Lines

libcxx/include/__format/parser_std_format_spec.h

Show All 27 Lines
#include <__format/format_parse_context.h> #include <__format/format_parse_context.h>
#include <__format/format_string.h> #include <__format/format_string.h>
#include <__format/unicode.h> #include <__format/unicode.h>
#include <__iterator/concepts.h> #include <__iterator/concepts.h>
#include <__iterator/readable_traits.h> // iter_value_t #include <__iterator/readable_traits.h> // iter_value_t
#include <__variant/monostate.h> #include <__variant/monostate.h>
#include <cstdint> #include <cstdint>
#include <string_view> #include <string_view>
#include <type_traits>
#if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER) #if !defined(_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER)
# pragma GCC system_header # pragma GCC system_header
#endif #endif
_LIBCPP_PUSH_MACROS _LIBCPP_PUSH_MACROS
#include <__undef_macros> #include <__undef_macros>
▲ Show 20 Lines • Show All 923 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx03.csv

Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Lines
format locale format locale
format optional format optional
format queue format queue
format stack format stack
format stdexcept format stdexcept
format string format string
format string_view format string_view
format tuple format tuple
format type_traits
format vector format vector
format version format version
forward_list algorithm forward_list algorithm
forward_list atomic forward_list atomic
forward_list compare forward_list compare
forward_list concepts forward_list concepts
forward_list cstddef forward_list cstddef
forward_list cstdint forward_list cstdint
▲ Show 20 Lines • Show All 590 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx11.csv

Show First 20 Lines • Show All 333 Lines • ▼ Show 20 Lines
format locale format locale
format optional format optional
format queue format queue
format stack format stack
format stdexcept format stdexcept
format string format string
format string_view format string_view
format tuple format tuple
format type_traits
format vector format vector
format version format version
forward_list algorithm forward_list algorithm
forward_list atomic forward_list atomic
forward_list compare forward_list compare
forward_list concepts forward_list concepts
forward_list cstddef forward_list cstddef
forward_list cstdint forward_list cstdint
▲ Show 20 Lines • Show All 591 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx14.csv

Show First 20 Lines • Show All 335 Lines • ▼ Show 20 Lines
format locale format locale
format optional format optional
format queue format queue
format stack format stack
format stdexcept format stdexcept
format string format string
format string_view format string_view
format tuple format tuple
format type_traits
format vector format vector
format version format version
forward_list algorithm forward_list algorithm
forward_list atomic forward_list atomic
forward_list compare forward_list compare
forward_list concepts forward_list concepts
forward_list cstddef forward_list cstddef
forward_list cstdint forward_list cstdint
▲ Show 20 Lines • Show All 598 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx17.csv

Show First 20 Lines • Show All 335 Lines • ▼ Show 20 Lines
format locale format locale
format optional format optional
format queue format queue
format stack format stack
format stdexcept format stdexcept
format string format string
format string_view format string_view
format tuple format tuple
format type_traits
format vector format vector
format version format version
forward_list algorithm forward_list algorithm
forward_list atomic forward_list atomic
forward_list compare forward_list compare
forward_list concepts forward_list concepts
forward_list cstddef forward_list cstddef
forward_list cstdint forward_list cstdint
▲ Show 20 Lines • Show All 598 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx20.csv

Show First 20 Lines • Show All 342 Lines • ▼ Show 20 Lines
format locale format locale
format optional format optional
format queue format queue
format stack format stack
format stdexcept format stdexcept
format string format string
format string_view format string_view
format tuple format tuple
format type_traits
format vector format vector
format version format version
forward_list algorithm forward_list algorithm
forward_list atomic forward_list atomic
forward_list compare forward_list compare
forward_list concepts forward_list concepts
forward_list cstddef forward_list cstddef
forward_list cstdint forward_list cstdint
▲ Show 20 Lines • Show All 596 Lines • Show Last 20 Lines

libcxx/test/libcxx/transitive_includes/cxx2b.csv

Show First 20 Lines • Show All 260 Lines • ▼ Show 20 Lines
format locale format locale
format optional format optional
format queue format queue
format stack format stack
format stdexcept format stdexcept
format string format string
format string_view format string_view
format tuple format tuple
format type_traits
format vector format vector
format version format version
forward_list compare forward_list compare
forward_list cstddef forward_list cstddef
forward_list cstdint forward_list cstdint
forward_list cstdlib forward_list cstdlib
forward_list cstring forward_list cstring
forward_list initializer_list forward_list initializer_list
▲ Show 20 Lines • Show All 438 Lines • Show Last 20 Lines