This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi] Adjust test_exception_storage.pass.cpp
AbandonedPublic

Authored by ldionne on Feb 21 2023, 7:33 AM.

Details

Reviewers
compnerd
miyuki
Group Reviewers
Restricted Project
Summary

Stop including the <unistd.h> and <__threading_support> headers in
single-threaded configurations (when these headers are not required).

Diff Detail

Event Timeline

miyuki created this revision.Feb 21 2023, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 7:33 AM
miyuki requested review of this revision.Feb 21 2023, 7:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 21 2023, 7:33 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
michaelplatings added inline comments.
libcxxabi/test/test_exception_storage.pass.cpp
11–12

I think these should be indented now e.g. # include <...>

miyuki updated this revision to Diff 499188.Feb 21 2023, 8:14 AM

Fixed indentation.

Maybe another member of the libc++abi group can approve this little change?

ldionne commandeered this revision.Sep 8 2023, 11:08 AM
ldionne edited reviewers, added: miyuki; removed: ldionne.

[Github PR transition cleanup]

Abandoning in favor of https://reviews.llvm.org/D138460.

ldionne abandoned this revision.Sep 8 2023, 11:08 AM