[libomptarget] Remove unused image from global data movement function

[jhuber6]

Summary

This interface function does not actually need the device image type.
It's unused in the function, so it should be able to be safely removed.
The motivation for this is to facilitate downsteam porting of the
amd-stg-open RPC module into the nextgen plugin so we can delete the old
plugin entirely. For that to work we need to be able to call this
function at kernel-launch time, which doesn't have the image. Also it's
cleaner.

[jplehr]

LGTM

openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.h

class GenericGlobalHandlerTy {
   Error moveGlobalBetweenDeviceAndHost(GenericDeviceTy &Device,
                                        DeviceImageTy &Image,
                                        const GlobalTy &HostGlobal,
                                        bool Device2Host);
 
   /// Actually move memory between host and device. See readGlobalFromDevice and
   /// writeGlobalToDevice for the interface description.
   Error moveGlobalBetweenDeviceAndHost(GenericDeviceTy &Device,
-                                       DeviceImageTy &Image,
                                        const GlobalTy &HostGlobal,
                                        const GlobalTy &DeviceGlobal,
                                        bool Device2Host);
 
 public:
   virtual ~GenericGlobalHandlerTy() {}
 
   /// Get the address and size of a global in the image. Address and size are
public:
   /// \p DeviceGlobal.
   virtual Error getGlobalMetadataFromDevice(GenericDeviceTy &Device,
                                             DeviceImageTy &Image,
                                             GlobalTy &DeviceGlobal) = 0;
 
   /// Copy the memory associated with a global from the device to its
   /// counterpart on the host. The name, size, and destination are defined by
   /// \p HostGlobal. The origin is defined by \p DeviceGlobal.
-  Error readGlobalFromDevice(GenericDeviceTy &Device, DeviceImageTy &Image,
+  Error readGlobalFromDevice(GenericDeviceTy &Device,
                              const GlobalTy &HostGlobal,
                              const GlobalTy &DeviceGlobal) {
-    return moveGlobalBetweenDeviceAndHost(Device, Image, HostGlobal,
-                                          DeviceGlobal,
+    return moveGlobalBetweenDeviceAndHost(Device, HostGlobal, DeviceGlobal,
                                           /* D2H */ true);
   }
 
   /// Copy the memory associated with a global from the device to its
   /// counterpart on the host. The name, size, and destination are defined by
   /// \p HostGlobal. The origin is automatically resolved.
   Error readGlobalFromDevice(GenericDeviceTy &Device, DeviceImageTy &Image,
                              const GlobalTy &HostGlobal) {
     return moveGlobalBetweenDeviceAndHost(Device, Image, HostGlobal,
                                           /* D2H */ true);
   }
 
   /// Copy the memory associated with a global from the host to its counterpart
   /// on the device. The name, size, and origin are defined by \p HostGlobal.
   /// The destination is defined by \p DeviceGlobal.
   Error writeGlobalToDevice(GenericDeviceTy &Device, DeviceImageTy &Image,
                             const GlobalTy &HostGlobal,
                             const GlobalTy &DeviceGlobal) {
-    return moveGlobalBetweenDeviceAndHost(Device, Image, HostGlobal,
-                                          DeviceGlobal,
+    return moveGlobalBetweenDeviceAndHost(Device, HostGlobal, DeviceGlobal,
                                           /* D2H */ false);
   }
 
   /// Copy the memory associated with a global from the host to its counterpart
   /// on the device. The name, size, and origin are defined by \p HostGlobal.
   /// The destination is automatically resolved.
   Error writeGlobalToDevice(GenericDeviceTy &Device, DeviceImageTy &Image,
                             const GlobalTy &HostGlobal) {

openmp/libomptarget/plugins-nextgen/common/PluginInterface/GlobalHandler.cpp

Error GenericGlobalHandlerTy::moveGlobalBetweenDeviceAndHost(
 
   GlobalTy DeviceGlobal(HostGlobal.getName(), HostGlobal.getSize());
 
   // Get the metadata from the global on the device.
   if (auto Err = getGlobalMetadataFromDevice(Device, Image, DeviceGlobal))
     return Err;
 
   // Perform the actual transfer.
-  return moveGlobalBetweenDeviceAndHost(Device, Image, HostGlobal, DeviceGlobal,
+  return moveGlobalBetweenDeviceAndHost(Device, HostGlobal, DeviceGlobal,
                                         Device2Host);
 }
 
 /// Actually move memory between host and device. See readGlobalFromDevice and
 /// writeGlobalToDevice for the interface description.
 Error GenericGlobalHandlerTy::moveGlobalBetweenDeviceAndHost(
-    GenericDeviceTy &Device, DeviceImageTy &DeviceImage,
-    const GlobalTy &HostGlobal, const GlobalTy &DeviceGlobal,
-    bool Device2Host) {
+    GenericDeviceTy &Device, const GlobalTy &HostGlobal,
+    const GlobalTy &DeviceGlobal, bool Device2Host) {
 
   // Transfer the data from the source to the destination.
   if (Device2Host) {
     if (auto Err =
             Device.dataRetrieve(HostGlobal.getPtr(), DeviceGlobal.getPtr(),
                                 HostGlobal.getSize(), nullptr))
       return Err;
   } else {