This is an archive of the discontinued LLVM Phabricator instance.

Differential D144400

[runtimes] Remove unused functions from Handle{Libcxx,Libunwind}Flags.cmake
ClosedPublic

Authored by philnik on Feb 20 2023, 8:13 AM.

Details

Reviewers
ldionne
phosek
Group Reviewers
Restricted Project
Restricted Project
Commits
rG141471a0cbf2: [runtimes] Remove unused functions from Handle{Libcxx,Libunwind}Flags.cmake

Diff Detail

Event Timeline

philnik created this revision.Feb 20 2023, 8:13 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 20 2023, 8:13 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Herald added a subscriber: libcxx-commits. · View Herald Transcript
philnik requested review of this revision.Feb 20 2023, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 20 2023, 8:13 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B214773: Diff 498864.Feb 20 2023, 8:14 AM
philnik updated this revision to Diff 499147.Feb 21 2023, 6:27 AM

Rebased

Harbormaster completed remote builds in B215001: Diff 499147.Feb 21 2023, 10:35 AM
phosek accepted this revision.Feb 21 2023, 2:36 PM

LGTM

philnik accepted this revision as: Restricted Project.Feb 21 2023, 3:38 PM
This revision is now accepted and ready to land.Feb 21 2023, 3:38 PM
Closed by commit rG141471a0cbf2: [runtimes] Remove unused functions from Handle{Libcxx,Libunwind}Flags.cmake (authored by philnik). · Explain WhyFeb 21 2023, 3:38 PM
This revision was automatically updated to reflect the committed changes.
philnik added a commit: rG141471a0cbf2: [runtimes] Remove unused functions from Handle{Libcxx,Libunwind}Flags.cmake.

Revision Contents

PathSize
libcxx/
cmake/
Modules/
43 lines
libunwind/
cmake/
Modules/
37 lines

Diff 499147

libcxx/cmake/Modules/HandleLibcxxFlags.cmake

Show All 30 Lines
macro(add_flags_if_supported) macro(add_flags_if_supported)
foreach(flag ${ARGN}) foreach(flag ${ARGN})
mangle_name("${flag}" flagname) mangle_name("${flag}" flagname)
check_cxx_compiler_flag("${flag}" "CXX_SUPPORTS_${flagname}_FLAG") check_cxx_compiler_flag("${flag}" "CXX_SUPPORTS_${flagname}_FLAG")
add_flags_if(CXX_SUPPORTS_${flagname}_FLAG ${flag}) add_flags_if(CXX_SUPPORTS_${flagname}_FLAG ${flag})
endforeach() endforeach()
endmacro() endmacro()
# Add a list of flags to 'LIBCXX_COMPILE_FLAGS'.
macro(add_compile_flags)
foreach(f ${ARGN})
list(APPEND LIBCXX_COMPILE_FLAGS ${f})
endforeach()
endmacro()
# If 'condition' is true then add the specified list of flags to
# 'LIBCXX_COMPILE_FLAGS'
macro(add_compile_flags_if condition)
if (${condition})
add_compile_flags(${ARGN})
endif()
endmacro()
# For each specified flag, add that flag to 'LIBCXX_COMPILE_FLAGS' if the
# flag is supported by the C++ compiler.
macro(add_compile_flags_if_supported)
foreach(flag ${ARGN})
mangle_name("${flag}" flagname)
check_cxx_compiler_flag("${flag}" "CXX_SUPPORTS_${flagname}_FLAG")
add_compile_flags_if(CXX_SUPPORTS_${flagname}_FLAG ${flag})
endforeach()
endmacro()
# Add a list of flags to 'LIBCXX_LINK_FLAGS'. # Add a list of flags to 'LIBCXX_LINK_FLAGS'.
macro(add_link_flags) macro(add_link_flags)
foreach(f ${ARGN}) foreach(f ${ARGN})
list(APPEND LIBCXX_LINK_FLAGS ${f}) list(APPEND LIBCXX_LINK_FLAGS ${f})
endforeach() endforeach()
endmacro() endmacro()
# If 'condition' is true then add the specified list of flags to
# 'LIBCXX_LINK_FLAGS'
macro(add_link_flags_if condition)
if (${condition})
add_link_flags(${ARGN})
endif()
endmacro()
# For each specified flag, add that flag to 'LIBCXX_LINK_FLAGS' if the
# flag is supported by the C++ compiler.
macro(add_link_flags_if_supported)
foreach(flag ${ARGN})
mangle_name("${flag}" flagname)
check_cxx_compiler_flag("${flag}" "CXX_SUPPORTS_${flagname}_FLAG")
add_link_flags_if(CXX_SUPPORTS_${flagname}_FLAG ${flag})
endforeach()
endmacro()
# Add a list of libraries or link flags to 'LIBCXX_LIBRARIES'. # Add a list of libraries or link flags to 'LIBCXX_LIBRARIES'.
macro(add_library_flags) macro(add_library_flags)
foreach(lib ${ARGN}) foreach(lib ${ARGN})
list(APPEND LIBCXX_LIBRARIES ${lib}) list(APPEND LIBCXX_LIBRARIES ${lib})
endforeach() endforeach()
endmacro() endmacro()
# if 'condition' is true then add the specified list of libraries and flags # if 'condition' is true then add the specified list of libraries and flags
Show All 18 Lines

libunwind/cmake/Modules/HandleLibunwindFlags.cmake

# HandleLibcxxFlags - A set of macros used to setup the flags used to compile # HandleLibcxxFlags - A set of macros used to setup the flags used to compile
# and link libc++abi. These macros add flags to the following CMake variables. # and link libc++abi. These macros add flags to the following CMake variables.
# - LIBUNWIND_COMPILE_FLAGS: flags used to compile libunwind # - LIBUNWIND_COMPILE_FLAGS: flags used to compile libunwind
# - LIBUNWIND_LINK_FLAGS: flags used to link libunwind # - LIBUNWIND_LINK_FLAGS: flags used to link libunwind
# - LIBUNWIND_LIBRARIES: libraries to link libunwind to. # - LIBUNWIND_LIBRARIES: libraries to link libunwind to.
include(CheckCCompilerFlag) include(CheckCCompilerFlag)
include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
include(HandleFlags) include(HandleFlags)
unset(add_flag_if_supported) unset(add_flag_if_supported)
# Add a specified list of flags to both 'LIBUNWIND_COMPILE_FLAGS' and
# 'LIBUNWIND_LINK_FLAGS'.
macro(add_flags)
foreach(value ${ARGN})
list(APPEND LIBUNWIND_COMPILE_FLAGS ${value})
list(APPEND LIBUNWIND_LINK_FLAGS ${value})
endforeach()
endmacro()
# If the specified 'condition' is true then add a list of flags to both
# 'LIBUNWIND_COMPILE_FLAGS' and 'LIBUNWIND_LINK_FLAGS'.
macro(add_flags_if condition)
if (${condition})
add_flags(${ARGN})
endif()
endmacro()
# Add each flag in the list to LIBUNWIND_COMPILE_FLAGS and LIBUNWIND_LINK_FLAGS
# if that flag is supported by the current compiler.
macro(add_flags_if_supported)
foreach(flag ${ARGN})
mangle_name("${flag}" flagname)
check_cxx_compiler_flag("${flag}" "CXX_SUPPORTS_${flagname}_FLAG")
add_flags_if(CXX_SUPPORTS_${flagname}_FLAG ${flag})
endforeach()
endmacro()
# Add a list of flags to 'LIBUNWIND_COMPILE_FLAGS'. # Add a list of flags to 'LIBUNWIND_COMPILE_FLAGS'.
macro(add_compile_flags) macro(add_compile_flags)
foreach(f ${ARGN}) foreach(f ${ARGN})
list(APPEND LIBUNWIND_COMPILE_FLAGS ${f}) list(APPEND LIBUNWIND_COMPILE_FLAGS ${f})
endforeach() endforeach()
endmacro() endmacro()
# If 'condition' is true then add the specified list of flags to # If 'condition' is true then add the specified list of flags to
Show All 24 Lines
# If 'condition' is true then add the specified list of flags to # If 'condition' is true then add the specified list of flags to
# 'LIBUNWIND_C_FLAGS' # 'LIBUNWIND_C_FLAGS'
macro(add_c_flags_if condition) macro(add_c_flags_if condition)
if (${condition}) if (${condition})
add_c_flags(${ARGN}) add_c_flags(${ARGN})
endif() endif()
endmacro() endmacro()
# For each specified flag, add that flag to 'LIBUNWIND_C_FLAGS' if the
# flag is supported by the C compiler.
macro(add_c_compile_flags_if_supported)
foreach(flag ${ARGN})
mangle_name("${flag}" flagname)
check_c_compiler_flag("${flag}" "C_SUPPORTS_${flagname}_FLAG")
add_c_flags_if(C_SUPPORTS_${flagname}_FLAG ${flag})
endforeach()
endmacro()
# Add a list of flags to 'LIBUNWIND_CXX_FLAGS'. # Add a list of flags to 'LIBUNWIND_CXX_FLAGS'.
macro(add_cxx_flags) macro(add_cxx_flags)
foreach(f ${ARGN}) foreach(f ${ARGN})
list(APPEND LIBUNWIND_CXX_FLAGS ${f}) list(APPEND LIBUNWIND_CXX_FLAGS ${f})
endforeach() endforeach()
endmacro() endmacro()
# If 'condition' is true then add the specified list of flags to # If 'condition' is true then add the specified list of flags to
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines