This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cov] Create syntax to pass source w/o binary.
ClosedPublic

Authored by mysterymath on Feb 16 2023, 11:00 AM.

Details

Summary

Since binary ID lookup makes CLI object arguments optional, it should be
possible to pass a list of source files without a binary. Unfortunately,
the current syntax will always interpret the first source file as a
binary. This change adds a -sources option to cause all later
positional arguments to be considered sources.

Diff Detail

Event Timeline

mysterymath created this revision.Feb 16 2023, 11:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2023, 11:00 AM
Herald added a subscriber: Enna1. · View Herald Transcript
mysterymath requested review of this revision.Feb 16 2023, 11:00 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptFeb 16 2023, 11:00 AM
Herald added subscribers: llvm-commits, Restricted Project. · View Herald Transcript

Correct .rst syntax.

gulfem accepted this revision.Feb 17 2023, 10:00 AM
gulfem added inline comments.
compiler-rt/test/profile/Linux/binary-id-lookup.c
14

Can you please extend this test to cover the following possible combinations in llvm-cov as well?

  1. object file(s) and source file(s)
  2. debug-file-directory, object file(s) and source file(s)
This revision is now accepted and ready to land.Feb 17 2023, 10:00 AM

Please remove the dot at the end of the commit message.

mysterymath marked an inline comment as done.

Address review feedback.

This revision was landed with ongoing or failed builds.Feb 17 2023, 1:11 PM
This revision was automatically updated to reflect the committed changes.