This is an archive of the discontinued LLVM Phabricator instance.

Differential D144117

[flang][runtime] Fix typo in assign.cpp
ClosedPublic

Authored by klausler on Feb 15 2023, 10:10 AM.

Details

Reviewers
vzakhari
Commits
rG114ce273d86a: [flang][runtime] Fix typo in assign.cpp
Summary

Variable name 'y' needs to be used in the declaration of 'yDesc'.

Diff Detail

Event Timeline

klausler created this revision.Feb 15 2023, 10:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2023, 10:10 AM
Herald added subscribers: sunshaoce, jdoerfert. · View Herald Transcript
klausler requested review of this revision.Feb 15 2023, 10:10 AM
vzakhari accepted this revision.Feb 15 2023, 10:11 AM
This revision is now accepted and ready to land.Feb 15 2023, 10:11 AM
This revision was landed with ongoing or failed builds.Feb 15 2023, 10:14 AM
Closed by commit rG114ce273d86a: [flang][runtime] Fix typo in assign.cpp (authored by klausler). · Explain Why
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG114ce273d86a: [flang][runtime] Fix typo in assign.cpp.
Harbormaster completed remote builds in B213931: Diff 497722.Feb 15 2023, 10:32 AM

Revision Contents

PathSize
flang/
runtime/
2 lines

Diff 497725

flang/runtime/assign.cpp

Show First 20 Lines • Show All 122 Lines • ▼ Show 20 Lines
} }
// Predicate: could the left-hand and right-hand sides of the assignment // Predicate: could the left-hand and right-hand sides of the assignment
// possibly overlap in memory? Note that the descriptors themeselves // possibly overlap in memory? Note that the descriptors themeselves
// are included in the test. // are included in the test.
static bool MayAlias(const Descriptor &x, const Descriptor &y) { static bool MayAlias(const Descriptor &x, const Descriptor &y) {
const char *xDesc{reinterpret_cast<const char *>(&x)}; const char *xDesc{reinterpret_cast<const char *>(&x)};
const char *xDescLast{xDesc + x.SizeInBytes()}; const char *xDescLast{xDesc + x.SizeInBytes()};
const char *yDesc{reinterpret_cast<const char *>(&x)}; const char *yDesc{reinterpret_cast<const char *>(&y)};
const char *yDescLast{yDesc + y.SizeInBytes()}; const char *yDescLast{yDesc + y.SizeInBytes()};
std::int64_t xLeast, xMost, yLeast, yMost; std::int64_t xLeast, xMost, yLeast, yMost;
MaximalByteOffsetRange(x, xLeast, xMost); MaximalByteOffsetRange(x, xLeast, xMost);
MaximalByteOffsetRange(y, yLeast, yMost); MaximalByteOffsetRange(y, yLeast, yMost);
const char *xBase{x.OffsetElement()}; const char *xBase{x.OffsetElement()};
const char *yBase{y.OffsetElement()}; const char *yBase{y.OffsetElement()};
if (RangesOverlap(xDesc, xDescLast, yBase + yLeast, yBase + yMost) || if (RangesOverlap(xDesc, xDescLast, yBase + yLeast, yBase + yMost) ||
RangesOverlap(yDesc, yDescLast, xBase + xLeast, xBase + xMost)) { RangesOverlap(yDesc, yDescLast, xBase + xLeast, xBase + xMost)) {
▲ Show 20 Lines • Show All 337 Lines • Show Last 20 Lines