This is an archive of the discontinued LLVM Phabricator instance.

[Fuchsia] Set /winsysroot in windows runtimes linker flags
ClosedPublic

Authored by haowei on Feb 13 2023, 3:53 PM.

Details

Summary

This patch sets '/winsysroot' flag when building Windows runtimes so we don't have to explicitly set Windows library search paths.

Diff Detail

Event Timeline

haowei created this revision.Feb 13 2023, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 3:53 PM
Herald added a subscriber: abrachet. · View Herald Transcript
haowei requested review of this revision.Feb 13 2023, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 13 2023, 3:53 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
phosek accepted this revision.Feb 14 2023, 12:13 AM

LGTM

clang/cmake/caches/Fuchsia-stage2.cmake
91–97

Can you please file an LLVM issue for this and reference it here?

This revision is now accepted and ready to land.Feb 14 2023, 12:13 AM
This revision was landed with ongoing or failed builds.Feb 14 2023, 1:32 PM
This revision was automatically updated to reflect the committed changes.