This is an archive of the discontinued LLVM Phabricator instance.

[X86] Add more tests for promoting `blendw` -> `blendd`; NFC
ClosedPublic

Authored by goldstein.w.n on Feb 10 2023, 3:32 PM.

Diff Detail

Event Timeline

goldstein.w.n created this revision.Feb 10 2023, 3:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 3:32 PM
Herald added a subscriber: pengfei. · View Herald Transcript
goldstein.w.n requested review of this revision.Feb 10 2023, 3:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 3:32 PM

Move logic to cancombinemask

RKSimon accepted this revision.Feb 13 2023, 6:46 AM

LGTM with a couple of minors

llvm/test/CodeGen/X86/shuffle-blendw.ll
3

You can probably reduce the number of check lines by adding common prefixes:

; RUN: llc < %s -mtriple=i686-unknown -mattr=+sse4.1 | FileCheck %s --check-prefixes=SSE41,X86-SSE41
; RUN: llc < %s -mtriple=x86_64-unknown -mattr=+sse4.1 | FileCheck %s --check-prefixes=SSE41,X64-SSE41
...
9

Add targets with AVX512 but not AVX512BW test coverage?

This revision is now accepted and ready to land.Feb 13 2023, 6:46 AM
goldstein.w.n added inline comments.Feb 13 2023, 8:42 AM
llvm/test/CodeGen/X86/shuffle-blendw.ll
9

Think some knl targets have avx512f w.o bw

@goldstein.w.n Why is this still dependent on D143787? It looks like its ready to be committed now

@goldstein.w.n Why is this still dependent on D143787? It looks like its ready to be committed now

Pushed the unrelated patches that have been approved.