This is an archive of the discontinued LLVM Phabricator instance.

Differential D143734

[NFC][clang][Modules] Refine test checks by adding `:`
ClosedPublic

Authored by Fznamznon on Feb 10 2023, 6:20 AM.

Details

Reviewers
ChuanqiXu
Bigcheese
Commits
rG440f45acff1c: [NFC][clang][Modules] Refine test checks by adding `:`
Summary

The test can fail if wokring directory where the test was launched
has a error substring in its path.

Diff Detail

Event Timeline

Fznamznon created this revision.Feb 10 2023, 6:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 6:20 AM
Fznamznon requested review of this revision.Feb 10 2023, 6:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 10 2023, 6:20 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ChuanqiXu accepted this revision.Feb 10 2023, 9:02 PM
This revision is now accepted and ready to land.Feb 10 2023, 9:02 PM
This revision was landed with ongoing or failed builds.Feb 21 2023, 7:18 AM
Closed by commit rG440f45acff1c: [NFC][clang][Modules] Refine test checks by adding `:` (authored by Fznamznon). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fznamznon added a commit: rG440f45acff1c: [NFC][clang][Modules] Refine test checks by adding `:`.

Revision Contents

PathSize
clang/
test/
Modules/
6 lines

Diff 499166

clang/test/Modules/libstdcxx-ambiguous-internal.cpp

// RUN: rm -rf %t // RUN: rm -rf %t
// RUN: %clang_cc1 -x c++ -std=c++11 -fmodules -emit-module -fmodule-name=std -fmodules-cache-path=%t %S/Inputs/libstdcxx-ambiguous-internal/module.modulemap -Werror // RUN: %clang_cc1 -x c++ -std=c++11 -fmodules -emit-module -fmodule-name=std -fmodules-cache-path=%t %S/Inputs/libstdcxx-ambiguous-internal/module.modulemap -Werror
// RUN: %clang_cc1 -x c++ -std=c++11 -fmodules -emit-module -fmodule-name=std -fmodules-cache-path=%t %S/Inputs/libstdcxx-ambiguous-internal/module.modulemap -fmodules-local-submodule-visibility -DAMBIGUOUS 2>&1| FileCheck %s // RUN: %clang_cc1 -x c++ -std=c++11 -fmodules -emit-module -fmodule-name=std -fmodules-cache-path=%t %S/Inputs/libstdcxx-ambiguous-internal/module.modulemap -fmodules-local-submodule-visibility -DAMBIGUOUS 2>&1| FileCheck %s
// CHECK-NOT: error // CHECK-NOT: error:
// CHECK: warning: ambiguous use of internal linkage declaration 'f' defined in multiple modules // CHECK: warning: ambiguous use of internal linkage declaration 'f' defined in multiple modules
// CHECK: note: declared here in module 'std.C' // CHECK: note: declared here in module 'std.C'
// CHECK: note: declared here in module 'std.B' // CHECK: note: declared here in module 'std.B'
// CHECK-NOT: error // CHECK-NOT: error:
// CHECK: warning: ambiguous use of internal linkage declaration 'n' defined in multiple modules // CHECK: warning: ambiguous use of internal linkage declaration 'n' defined in multiple modules
// CHECK: note: declared here in module 'std.C' // CHECK: note: declared here in module 'std.C'
// CHECK: note: declared here in module 'std.B' // CHECK: note: declared here in module 'std.B'
// CHECK-NOT: error // CHECK-NOT: error: