This is an archive of the discontinued LLVM Phabricator instance.

[lit] don't skip test times when executions are instantaneous
ClosedPublic

Authored by ashay-github on Feb 7 2023, 8:20 AM.

Details

Summary

If a test executes quickly or if the timing resolution is too coarse,
the running time associated with a test could be zero. This happens
often for the //llvm/utils/lit/tests/reorder.py test on Windows, which
causes the test to fail non-deterministically.

This patch modifies the existing check, so that instead of skipping
zeros, lit now skips if the timing is None (presumably due to an error
in measurement). Recurring executions of the reorder.py test on Windows
seem to indicate that the test no longer exhibits occasional failure.

Diff Detail

Event Timeline

ashay-github created this revision.Feb 7 2023, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 8:20 AM
Herald added a subscriber: delcypher. · View Herald Transcript
ashay-github requested review of this revision.Feb 7 2023, 8:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 8:20 AM
This revision is now accepted and ready to land.Feb 7 2023, 11:24 AM