This is an archive of the discontinued LLVM Phabricator instance.

[libc++][CI] Starts using Clang 17.
ClosedPublic

Authored by Mordante on Feb 7 2023, 2:11 AM.

Details

Reviewers
ldionne
Mordante
Group Reviewers
Restricted Project
Commits
rGa41e1ea2a746: [libc++][CI] Starts using Clang 17.

Diff Detail

Event Timeline

Mordante created this revision.Feb 7 2023, 2:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 2:11 AM
Herald added a subscriber: arichardson. · View Herald Transcript
Mordante requested review of this revision.Feb 7 2023, 2:11 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2023, 2:11 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik added a subscriber: philnik.Feb 7 2023, 2:15 AM
philnik added inline comments.
libcxx/utils/ci/buildkite-pipeline.yml
293

Why don't you remove the Clang 14 run?

Mordante added inline comments.Feb 7 2023, 6:11 AM
libcxx/utils/ci/buildkite-pipeline.yml
293

We typically do that after the release branch is released. Then we also can cleanup the clang 14 work-arounds if needed.

ldionne accepted this revision.Feb 14 2023, 9:03 AM
ldionne added a subscriber: ldionne.
ldionne added inline comments.
libcxx/utils/ci/buildkite-pipeline.yml
293

FWIW I would be OK with removing the 14 run in this patch, but no strong preference.

This revision is now accepted and ready to land.Feb 14 2023, 9:03 AM
Mordante updated this revision to Diff 497379.Feb 14 2023, 10:18 AM

Rebased and addresses review comments

Mordante accepted this revision.Feb 14 2023, 10:19 AM
Mordante marked 2 inline comments as done.

Thanks for the reviews!

libcxx/utils/ci/buildkite-pipeline.yml
293

I don't feel to strongly about the "current" process. So I've removed it.
(Especially since I want to give the patch a spin before landing it.)

Mordante updated this revision to Diff 497680.Feb 15 2023, 7:56 AM
Mordante marked an inline comment as done.

Try to fix CI.

This revision was landed with ongoing or failed builds.Feb 15 2023, 10:19 AM
This revision was automatically updated to reflect the committed changes.