Details
Details
- Reviewers
ldionne - Group Reviewers
Restricted Project - Commits
- rG8e13ec9eca1f: [libc++] In tests, use `abort` to terminate upon an error.
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
@ldionne asked the same here https://reviews.llvm.org/D142808#inline-1381137. This may lead to merge conflicts. So if this patch is not urgent I have a slight preference to abandon it.
Otherwise LGTM!
Comment Actions
This actually fixes some issues for us internally, so I'd like to ship it soon and even cherry-pick on release/16.x. The rebase should be realllly easy.
Comment Actions
Of course the rebase in easy, but I would like to prevent it if possible ;-)
Fixing issues for Apple internally sounds like a good reason to ship it and cherry-pick it for LLVM 16.