This is an archive of the discontinued LLVM Phabricator instance.

[libc++] In tests, use `abort` to terminate upon an error.
ClosedPublic

Authored by var-const on Feb 2 2023, 11:58 PM.

Details

Reviewers
ldionne
Group Reviewers
Restricted Project
Commits
rG8e13ec9eca1f: [libc++] In tests, use `abort` to terminate upon an error.

Diff Detail

Event Timeline

var-const created this revision.Feb 2 2023, 11:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 11:58 PM
var-const requested review of this revision.Feb 2 2023, 11:58 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2023, 11:58 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne accepted this revision.Feb 3 2023, 11:15 AM
This revision is now accepted and ready to land.Feb 3 2023, 11:15 AM

@ldionne asked the same here https://reviews.llvm.org/D142808#inline-1381137. This may lead to merge conflicts. So if this patch is not urgent I have a slight preference to abandon it.

Otherwise LGTM!

This actually fixes some issues for us internally, so I'd like to ship it soon and even cherry-pick on release/16.x. The rebase should be realllly easy.

This revision was landed with ongoing or failed builds.Feb 10 2023, 11:32 AM
This revision was automatically updated to reflect the committed changes.

This actually fixes some issues for us internally, so I'd like to ship it soon and even cherry-pick on release/16.x. The rebase should be realllly easy.

Of course the rebase in easy, but I would like to prevent it if possible ;-)
Fixing issues for Apple internally sounds like a good reason to ship it and cherry-pick it for LLVM 16.